Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no audio in output videos #919

Closed
wants to merge 1 commit into from
Closed

Conversation

Baronsindo
Copy link

i removed '-an'
because of it the outputted videos has no sound

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

i removed '-an'
because of it the outputted videos has no sound
@Overdrivr
Copy link
Collaborator

Overdrivr commented Mar 28, 2019

Thanks for your contribution, does this PR refers to #876 ?
Could you write a test case demonstrating the lack of audio in the exported file ?

@Overdrivr Overdrivr added the tests-needed PRs/code submissions which need test cases added to them. label Mar 28, 2019
@ThePhonon
Copy link
Contributor

ThePhonon commented Jun 4, 2019

Note: the -an option is arguably needed. The bug is that it is not provided before the '-i' option.
See #968

@Baronsindo
Copy link
Author

Thanks for clearing that out.

@tburrows13
Copy link
Collaborator

The general census seems to be that #968 should be merged, not this one.

@tburrows13 tburrows13 closed this Feb 24, 2020
@tburrows13 tburrows13 added duplicate Duplicate of another issue/PR. bug-fix For PRs and issues solving bugs. lib-FFmpeg Issues pertaining to dependency FFmpeg. and removed tests-needed PRs/code submissions which need test cases added to them. labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs. duplicate Duplicate of another issue/PR. lib-FFmpeg Issues pertaining to dependency FFmpeg.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants