Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalize flake8 linting #1439

Merged
merged 17 commits into from
Jan 16, 2021
Merged

Formalize flake8 linting #1439

merged 17 commits into from
Jan 16, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 14, 2021 •
edited
Loading

Closes #1435

  • Added lint optional requirements to setup.py.
  • Fixed all linting problems in tests/, moviepy/ and examples/.
  • Relative imports converted to absolute ones (this is linted also).
  • Added documentation about how to format and lint the code in README.
  • Moved CI flake8 configuration to setup.cfg file.
  • Separated CI linting in 4 different steps:
    • scripts (setup.py, docs/conf.py and find_latest_imagemagick_version.py)
    • examples
    • tests
    • moviepy
  • Removed uneeded # -*- coding: utf-8 -*- statements.
  • Removed uneeded __future__ imports.
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja added the tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. label Jan 14, 2021
@mondeja mondeja marked this pull request as draft January 14, 2021 11:21
@mondeja mondeja added the refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. label Jan 14, 2021
@mondeja mondeja mentioned this pull request Jan 14, 2021
Merged
2 tasks
@coveralls
Copy link

coveralls commented Jan 15, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 66.157% when pulling 02f8d78 on mondeja:flake8 into 4c93a6f on Zulko:master.

@mondeja mondeja marked this pull request as ready for review January 15, 2021 23:22
@mondeja mondeja marked this pull request as draft January 16, 2021 00:32
@mondeja

This comment has been minimized.

Sign in to view
@mondeja mondeja marked this pull request as ready for review January 16, 2021 01:03
@mondeja mondeja merged commit 72e1418 into Zulko:master Jan 16, 2021
@mondeja mondeja mentioned this pull request Jan 18, 2021
Closed
2 tasks
tburrows13 pushed a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
@mondeja @tburrows13
Formalize flake8 linting (Zulko#1439)
36c6009 
* Fix flake8 errors (except complexity < 10 restriction) and configure from file

* Lint tests; add 'flake8-implicit-str-concat'; add optional reqs 'lint'

* Remove blank lines at the end of 'setup.cfg'

* Refactor 'os' imports in 'tests/test_resourcerelease.py'

* Fix new flake8 errors

* Add linting and formatting instructions to README

* Fix black dep version definition in setup

* Convert relative imports into absolute ones; add relative imports linting

* Fix error in lint dependency

* Fix errors and improve flake8 config comments

* Ignores rules in 'editor.py' using configuration

* Removed uneeded '# -*- coding: utf-8 -*-' statements

* Remove '__future__' imports

* Minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees
No one assigned
Labels
refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up flake8 code check properly
3 participants
@mondeja @coveralls @tburrows13