Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutout error fixed #1360

Closed

Conversation

rishabhvarshney14
Copy link

@rishabhvarshney14 rishabhvarshney14 commented Oct 20, 2020

related to #1227

I have tested these functions that used the apply_to_audio decorator

  • with_start
  • with_end
  • with_duration
  • subclip
  • cutout
  • loop
  • time_mirror
  • time_symmetrize

I have an issue with with_start. I am not sure what with_start suppose to do as compared to with_end with_start does not start with the expected starting time also time_mirror and time_symmetry gave error the same as here #1253.

Also in speedx.py it imports apply_to_audio and apply_to_mask but does not use it. Is this correct? Fixed

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have formatted my code using black -t py36

@coveralls
Copy link

coveralls commented Oct 20, 2020

Coverage Status

Coverage remained the same at 67.46% when pulling ca7a640 on rishabhvarshney14:cutoutcuttwice into 4193286 on Zulko:master.

@tburrows13 tburrows13 added bug-fix For PRs and issues solving bugs. hacktoberfest-accepted For Hacktoberfest PRs. See https://hacktoberfest.digitalocean.com/faq labels Oct 25, 2020
@mondeja
Copy link
Collaborator

mondeja commented Jan 18, 2021

Also in speedx.py it imports apply_to_audio and apply_to_mask but does not use it. Is this correct?

All module imports not used are has been removed in #1439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs. hacktoberfest-accepted For Hacktoberfest PRs. See https://hacktoberfest.digitalocean.com/faq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants