-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release Zebra 1.0.0-beta.15 #5194
Conversation
Here's how I made the release PR:
I combined or deleted these PRs in the draft changelog:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5194 +/- ##
==========================================
+ Coverage 79.14% 79.27% +0.12%
==========================================
Files 307 307
Lines 39218 39218
==========================================
+ Hits 31040 31090 +50
+ Misses 8178 8128 -50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. I'm requesting changes just because of two small typos.
I realized it's easier to approve the PR since we don't merge PRs until all conversations are resolved anyway. (It's funny because I've been doing it this way for ages. I don't know what I was thinking when I was requesting the changes.) |
Co-authored-by: Marek <mail@marek.onl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested cargo install --locked --git https://github.com/ZcashFoundation/zebra --branch beta-15-release zebra
on macOS 12.6 on an M1, installed and ran successfully
Closes #5011
Versioning
Which Crates to Increment
To check if any of the top-level crates need version increments:
Alternatively you can:
main
branch against the last tag (Example)git diff --stat <previous-release-tag> origin/main
Once you know which crates have changed:
How to Increment Versions
Zebra follows semantic versioning.
Semantic versions look like: MAJOR
.
MINOR.
PATCH[-
TAG.
PRE-RELEASE]Reviewing Version Bumps
Check for missed changes by going to:
https://github.com/ZcashFoundation/zebra/tree/<commit-hash>/
Where
<commit-hash>
is the hash of the last commit in the version bump PR.If any Zebra or Tower crates have commit messages that are not a version bump, we have missed an update.
Also check for crates that depend on crates that have changed. They should get a version bump as well.
Version Locations
Once you know which versions you want to increment, you can find them in the:
Cargo.toml
sCargo.toml
szebra-network
protocol user agent: https://github.com/ZcashFoundation/zebra/blob/main/zebra-network/src/constants.rsREADME.md
book/src/user/install.md
Cargo.lock
: automatically generated bycargo build
Version Tooling
You can use
fastmod
to interactively find and replace versions.For example, you can do something like:
If you use
fastmod
, don't update versions inCHANGELOG.md
.README
We should update the README to:
Check for changes in the
Dockerfile
since the last tag:git diff <previous-release-tag> docker/Dockerfile
.Checkpoints
With every release and for performance reasons, we want to update the zebra checkpoints. More information on how to do this can be found in the zebra-checkpoints README.
To do this you will need a synchronized
zcashd
node. You can request help from other zebra team members to submit this PR if you can't make it yourself at the moment of the release.Change Log
Important: Any merge into
main
deletes any edits to the draft changelog.Once you are ready to tag a release, copy the draft changelog into
CHANGELOG.md
.We follow the Keep a Changelog format.
We use the Release Drafter workflow to automatically create a draft changelog.
To create the final change log:
CHANGELOG.md
Change Categories
From "Keep a Changelog":
Added
for new features.Changed
for changes in existing functionality.Deprecated
for soon-to-be removed features.Removed
for now removed features.Fixed
for any bug fixes.Security
in case of vulnerabilities.Create the Release
Create the Release PR
After you have the version increments, the updated checkpoints and the updated changelog:
(name suggestion, example:
v1.0.0-alpha.0-release
)&template=release-checklist.md
to thecomparing url (Example).
Do not unfreeze the whole repository.
Create the Release
create a new release using the draft release as a base,
by clicking the Edit icon in the draft release
for example:
v1.0.0-alpha.0
main
branchZebra
followed by the version tag,for example:
Zebra 1.0.0-alpha.0
changelog you created; starting just after the title
## [Zebra ...
ofthe current version being released, and ending just before the title of
the previous release.
Build and Binary Testing
cargo install
command inREADME.md
works(
--git
behaves a bit differently to--path
)~/.cargo/bin/zebrad
main
, and the quick tests have passed.(You can ignore the full sync and
lightwalletd
tests, because they take about a day to run.)If the build fails after tagging:
README.md
with a new git tagCHANGELOG.md
with details about the fix