Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clippy): Resolve unnecessary borrow lint and remove redundant imports #5045

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 2, 2022

Motivation

We want to keep clippy lints up to date by doing them when they arrive in nightly Rust.

Solution

Partly generated by:

cargo +nightly clippy --fix --all-features --all-targets

Review

This just needs to get fixed eventually.

Reviewer Checklist

  • CI passes

```sh
cargo clippy --fix --all-features --all-targets
```
@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Low ❄️ labels Sep 2, 2022
@teor2345 teor2345 requested a review from a team as a code owner September 2, 2022 03:49
@teor2345 teor2345 self-assigned this Sep 2, 2022
@teor2345 teor2345 requested review from a team as code owners September 2, 2022 03:49
@teor2345 teor2345 requested review from dconnolly and oxarbitrage and removed request for a team September 2, 2022 03:49
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #5045 (806fc41) into main (0c4be38) will increase coverage by 0.00%.
The diff coverage is 26.31%.

@@           Coverage Diff           @@
##             main    #5045   +/-   ##
=======================================
  Coverage   79.16%   79.17%           
=======================================
  Files         310      310           
  Lines       38900    38897    -3     
=======================================
- Hits        30797    30795    -2     
+ Misses       8103     8102    -1     

@dconnolly
Copy link
Contributor

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergify bot added a commit that referenced this pull request Sep 2, 2022
@mergify mergify bot merged commit 66ea40f into main Sep 2, 2022
@mergify mergify bot deleted the clippy-2022-09-02 branch September 2, 2022 18:20
@teor2345 teor2345 mentioned this pull request Sep 19, 2022
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants