Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(test): Stop requiring cached lightwalletd state for the send transaction test #4302

Merged
merged 3 commits into from
May 5, 2022
Merged

change(test): Stop requiring cached lightwalletd state for the send transaction test #4302

merged 3 commits into from
May 5, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 5, 2022

Motivation

We want to get the send transaction test working soon.

This PR stops requiring cached lightwalletd state for the send transaction tests.
(We can add the cached lightwalletd state later.)

Solution

  • Temporarily stop requiring cached lightwalletd state for the send transaction test

Related fixes:

  • In tests, expect a Zebra cached state that is near the tip
  • Consistently use the same zebrad timeouts and failure conditions in lightwalletd tests

Review

This PR blocks PR #4267, it is urgent.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

@teor2345 teor2345 added A-rust Area: Updates to Rust code A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels May 5, 2022
@teor2345 teor2345 self-assigned this May 5, 2022
@teor2345 teor2345 requested a review from a team as a code owner May 5, 2022 02:14
@teor2345 teor2345 requested review from upbqdn and dconnolly and removed request for a team and upbqdn May 5, 2022 02:14
@teor2345 teor2345 changed the title change(test): Stop requiring cached lightwalletd state for the send transaction tests change(test): Stop requiring cached lightwalletd state for the send transaction test May 5, 2022
@teor2345 teor2345 mentioned this pull request May 5, 2022
Merged
3 tasks
@teor2345
Copy link
Contributor Author

teor2345 commented May 5, 2022

Error: buildx failed with: error: failed to solve: failed to compute cache key: failed to copy: read tcp 172.17.0.2:34284->20.60.6.228:443: read: connection timed out

@mergify mergify bot mentioned this pull request May 5, 2022
Closed
40 tasks
mergify bot added a commit that referenced this pull request May 5, 2022
@mergify
Merge of #4302
c770541
@mergify mergify bot mentioned this pull request May 5, 2022
Closed
40 tasks
@mergify mergify bot merged commit 5cd1133 into main May 5, 2022
@mergify mergify bot deleted the send-tx-no-lwd-state branch May 5, 2022 04:44
@teor2345 teor2345 mentioned this pull request May 5, 2022
Merged
2 tasks
@conradoplg conradoplg mentioned this pull request May 6, 2022
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-testing Category: These are tests lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly