feat(ci): add `lightwalletd_full_sync` test to CI #4268

gustavovalverde · 2022-05-02T20:53:07Z

Motivation

We want to add all completed lightwalletd integration tests to CI, to confirm we're not introducing bugs to the RPC endpoints or any other implementation related to lightwalletd

Fixes #3926
Fixes #4165
Depends-On: #4298

Designs

Consider the implementations being done in test.yml and test-full-sync.yml

Solution

Add lightwalletd_full_sync test to CI
Add lightwalletd_full_sync to entrypoint.sh for easier execution

Review

Anyone from the DevOps team can review this

Reviewer Checklist

Verify tests are using the right execution methods
Confirm job id, step names and description

Follow Up Work

Simplify this job with the refactor being done for reusable workflows

This is a workaround for an issue related to disk partitioning, caused by a GCP service called Konlet, while mounting the cached disks to the VM and then to the container

.github/workflows/zcash-lightwalletd.yml

.github/workflows/continous-integration-docker.yml

.github/workflows/deploy-gcp-tests.yml

teor2345

I'm still not quite sure if we're mounting the disks correctly, it seems like we mount the same disk twice to two different paths.

(Does that even work?)

Maybe we could deal with these questions in a separate PR.

.github/workflows/deploy-gcp-tests.yml

teor2345

Thanks, that makes more sense now.

.github/workflows/deploy-gcp-tests.yml

teor2345

I'm happy for someone else to approve the PR tomorrow, I think we're just working on docs now.

Co-authored-by: teor <teor@riseup.net>

gustavovalverde · 2022-05-13T04:47:45Z

We've fixed the conflicts and documented some confusing implementations. As this is working so far, I think this is good to go.

.github/workflows/deploy-gcp-tests.yml

dconnolly

Small typo fix, non blocking, this is great 💯📜✨👌🧑‍🍳

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>

gustavovalverde · 2022-05-13T14:35:53Z

Oops, the typo fix dismissed your approval @dconnolly

conradoplg

The comments are very helpful, thanks!

gustavovalverde added 30 commits April 29, 2022 16:52

feat(ci): add lightwalletd_*_sync tests to CI

1aae93e

feat(ci): add lightwalletd RPC call test

d2e2e2f

feat(ci): add send transactions test with lwd to CI

7333d4b

fix(ci): create a variable to run transactions test

e209289

refactor(ci): use docker in docker

66ae72a

This is a workaround for an issue related to disk partitioning, caused by a GCP service called Konlet, while mounting the cached disks to the VM and then to the container

fix(build): persist docker login credentials

cd7c9d2

fix(ci): get sync height from docker logs instead of gcp

4c82d76

try: use gha cache for faster building

7759333

fix(ci): mount disk in container to make it available in vm

501e74a

fix(build): do not invalidate cache between images

865dd94

try(docker): invalidate cache as less as possible

0b00f41

fix(ci): GHA terminal is not a TTY

9dbd569

fix(build): do not ignore entrypoint.sh

54db94b

fix

7a4945b

fix(ci): mount using root priveleges

fd37a02

fix(ci): use existing disk as cached state

fc6e20b

fix(ci): wait for disks to get mounted

6f622f6

force rebuild

4306444

fix failed force

d053daf

fix failed commit

e8ef913

WIP

14ee447

Merge branch 'main' into ci-gcp-disk

732e187

fix(ci): some tests does not use a cached state

6da4254

wip

50ffb12

Merge branch 'ci-gcp-disk' into ref-test-deployment

80cbf67

refactor(ci): disk names and job segregation

203041f

fix(ci): do not name boot and attached disk the same

57021db

fix(ci): attach a disk to full sync, to snapshot the state

3f77965

Merge branch 'ci-gcp-disk' into ref-test-deployment

e914a17

Merge branch 'main' into lwd-ci-test

725ce80

dconnolly reviewed May 12, 2022

View reviewed changes

.github/workflows/zcash-lightwalletd.yml Show resolved Hide resolved

teor2345 mentioned this pull request May 12, 2022

0. fix(ci): only use cached state disks with the same state version #4391

Merged

3 tasks