Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
zcash_script
has a new API due to ZIP-244 changes that we must use.In order to use it, we also need the updated
librustzcash
which also had API changes.Specifications
Designs
Solution
librustzcash
APISplit from #3799
Part of #3520
Closes #3056
Review
This was split from #3799 which was reviewed by @teor2345
This is blocked on ZcashFoundation/zcash_script#30 (which is also blocked) so it's a draft, but it can already be reviewed.
This blocks the testnet reactivation test, so it's important.
Reviewer Checklist
Follow Up Work