Update zcash to new V5 API; add tests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Mar 2, 2022
teor2345
previously approved these changes
Mar 2, 2022
conradoplg
force-pushed
the
zcash_script_v5_api
branch
2 times, most recently
from
84f568e to
579c0c0
Compare
|
@teor2345 this is ready again - I fixed the comment. (I tried to add a V5 test but realized that particular test vector wasn't supposed to work) |
|
Ah, forgot that we need to wait for the |
3 tasks
teor2345
previously approved these changes
Mar 8, 2022
3 tasks
conradoplg
force-pushed
the
zcash_script_v5_api
branch
2 times, most recently
from
38bb9f4 to
465ba58
Compare
conradoplg
force-pushed
the
zcash_script_v5_api
branch
from
465ba58 to
468cb28
Compare
conradoplg
commented
Mar 24, 2022
upbqdn
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the new V5
zcash_scriptfunctions, which implement ZIP-244 changes, see zcash/zcash#5607This points to that PR (it must be updated after it's merged, so it's a draft PR for now) and add tests.