Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): only run lightwalletd test when the ZEBRA_TEST_LIGHTWALLETD env var is set #3627

Merged
merged 2 commits into from
Feb 24, 2022
Merged

fix(test): only run lightwalletd test when the ZEBRA_TEST_LIGHTWALLETD env var is set #3627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce54111
fix(test): only run lightwalletd test when the ZEBRA_TEST_LIGHTWALLET…
teor2345 Feb 24, 2022
4cb28f1
fix(test): actually skip the test
teor2345 Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions zebrad/tests/acceptance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ use color_eyre::{
};
use tempfile::TempDir;

use std::{
collections::HashSet, convert::TryInto, env, net::SocketAddr, path::Path, path::PathBuf,
time::Duration,
};
use std::{collections::HashSet, convert::TryInto, env, path::Path, path::PathBuf, time::Duration};

use zebra_chain::{
block::Height,
Expand Down Expand Up @@ -1459,13 +1456,29 @@ async fn tracing_endpoint() -> Result<()> {

/// Launch `zebrad` with an RPC port, and make sure `lightwalletd` works with Zebra.
///
/// This test doesn't work on Windows, and it is ignored by default on other platforms.
/// This test only runs when the `ZEBRA_TEST_LIGHTWALLETD` env var is set.
///
/// This test doesn't work on Windows, so it is always skipped on that platform.
#[test]
#[ignore]
#[cfg(not(target_os = "windows"))]
fn lightwalletd_integration() -> Result<()> {
use std::net::SocketAddr;

zebra_test::init();

// Skip the test unless we specifically asked for it
//
// TODO: check if the lightwalletd binary is in the PATH?
// (this doesn't seem to be implemented in the standard library)
if env::var("ZEBRA_TEST_LIGHTWALLETD").is_err() {
tracing::info!(
"skipped lightwalletd integration test, \
set the 'ZEBRA_TEST_LIGHTWALLETD' environmental variable to run the test",
);

return Ok(());
}

// Launch zebrad

// [Note on port conflict](#Note on port conflict)
Expand Down