Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): only run lightwalletd test when the ZEBRA_TEST_LIGHTWALLETD env var is set #3627

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

PR #3619 made one of the CI tests fail. This is a simple fix.

Review

@gustavovalverde can review this PR, or anyone else.

This fix is needed to allow other PRs to merge, because their tests are currently failing.

Reviewer Checklist

  • "Test all" passes

Follow Up Work

Set ZEBRA_TEST_LIGHTWALLETD in:

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures A-rpc Area: Remote Procedure Call interfaces labels Feb 24, 2022
@teor2345 teor2345 self-assigned this Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #3627 (4cb28f1) into main (78a05bc) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3627   +/-   ##
=======================================
  Coverage   79.89%   79.90%           
=======================================
  Files         281      281           
  Lines       32582    32582           
=======================================
+ Hits        26032    26035    +3     
+ Misses       6550     6547    -3     

Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mergify bot added a commit that referenced this pull request Feb 24, 2022
@mergify mergify bot merged commit 957a150 into main Feb 24, 2022
@mergify mergify bot deleted the lightwalletd-rpc-test-fix branch February 24, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants