Add proptest regressions for redpallas::prop::tweak_signature #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These regressions make `spendauth.check()` fail.
teor2345
added
C-bug
This was referenced May 20, 2021
Log instead of failing the redpallas::prop::tweak_signature test, and add proptest regressions
#2169
Merged
|
I think this is unrelated to the binding sig issues, but may reveal an issue with an assumption with how we use the prime order curve in these tweak tests. |
I just found another regression, let's disable those tests? |
|
Merged into #2169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
redpallas::prop::tweak_signature'sspendauth.check()fails on the proptest seeds in this PR.Solution
This cryptographic error seems like a job for @dconnolly or @conradoplg.
Review
This PR should only be merged once the regressions are fixed.
Related Issues
Sapling binding signatures fail in #1939. This suggests there might be some bug in the common Orchard/Sapling code, or in the code that was copied from Sapling to Orchard.
(However, binding signatures and spendauth signatures have some differences, so 🤷.)
Related Issues
Regression PR #2168
Temporarily disable test PR #2169
Underlying fix ticket #2170
Follow Up Work
See #2170