Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orchard spend auth signature regressions #2170

Closed
2 tasks
teor2345 opened this issue May 20, 2021 · 1 comment · Fixed by #2219 or #2228
Closed
2 tasks

Fix orchard spend auth signature regressions #2170

teor2345 opened this issue May 20, 2021 · 1 comment · Fixed by #2219 or #2228
Assignees
@dconnolly
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug S-needs-investigation Status: Needs further investigation
Milestone
2021 Sprint 10

Comments

@teor2345
Copy link
Contributor

teor2345 commented May 20, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

#2168 contains some proptest regressions that cause the redpallas::prop::tweak_signature test's spend auth signature check to fail.

Describe the solution you'd like

Describe alternatives you've considered

Delete the tests if they are unreliable.

Related issues

Regression PR #2168
Temporarily disable test PR #2169
Underlying fix ticket #2170
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage S-needs-investigation Status: Needs further investigation P-Medium labels May 20, 2021
@teor2345 teor2345 added this to the 2021 Sprint 11 - Zcon2 milestone May 20, 2021
@teor2345 teor2345 mentioned this issue May 20, 2021
Closed
@dconnolly
Copy link
Contributor

This is interesting, I need to check the tweaks, these failures are not related to the binding signature verification key computation failures.

@teor2345 teor2345 mentioned this issue May 20, 2021
Merged
@dconnolly dconnolly self-assigned this May 24, 2021
dconnolly added a commit that referenced this issue May 27, 2021
@dconnolly
Get redpallas tweak proptests working again
bcab0eb 
Instead of creating an invalid verification key for a particular signature by tweaking its bytes,
create another verification key and when the ChangePubkey tweak is applied, just swap out the correct
SignatureCase::pk_bytes for SignatureCase::invalid_pk_bytes and check that trying to verify the signature
using that wrong key fails, as expected.

Resolves #2170
@dconnolly dconnolly mentioned this issue May 27, 2021
Merged
2 tasks
teor2345 pushed a commit that referenced this issue May 27, 2021
@dconnolly
Get redpallas tweak proptests working again (#2219)
a5f5913 
Instead of creating an invalid verification key for a particular signature by tweaking its bytes,
create another verification key and when the ChangePubkey tweak is applied, just swap out the correct
SignatureCase::pk_bytes for SignatureCase::invalid_pk_bytes and check that trying to verify the signature
using that wrong key fails, as expected.

Resolves #2170
@dconnolly dconnolly mentioned this issue May 31, 2021
Merged
2 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug S-needs-investigation Status: Needs further investigation
Projects
None yet
Milestone
2021 Sprint 10
3 participants
@dconnolly @mpguerra @teor2345