Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加Docker构建脚本 #322

Merged
merged 3 commits into from
Sep 25, 2024
Merged

添加Docker构建脚本 #322

merged 3 commits into from
Sep 25, 2024

Conversation

cnzgray
Copy link
Contributor

@cnzgray cnzgray commented Jun 14, 2024

添加了docker构建支持,利用github actions自动构建docker镜像,并推送到github的package中。

PS:作者要注意修改下packages的访问权限。

@StevesHarrington
Copy link

是有docker版了吗?在哪里pull

@glyh
Copy link
Collaborator

glyh commented Sep 24, 2024

构建系统更新成poetry了,请问可以麻烦更新一下docker脚本吗,感谢 :) 。
可以参考这里

@cnzgray cnzgray force-pushed the feat/docker_support branch from aa1d57d to 1457d03 Compare September 25, 2024 00:45
@glyh
Copy link
Collaborator

glyh commented Sep 25, 2024

以及,有办法不复制一份config.ini吗

@cnzgray cnzgray force-pushed the feat/docker_support branch 4 times, most recently from ba9a941 to 479ebfe Compare September 25, 2024 03:50
@cnzgray
Copy link
Contributor Author

cnzgray commented Sep 25, 2024

已经处理,请评审。

@cnzgray cnzgray force-pushed the feat/docker_support branch from 479ebfe to 693f54e Compare September 25, 2024 03:52
@glyh
Copy link
Collaborator

glyh commented Sep 25, 2024

版本号生成似乎有点问题:

image

因为必须要读取git tags,所以在build的时候要像actions里那样,pull下来之后要先运行:

git fetch --prune --unshallow --tags

@glyh
Copy link
Collaborator

glyh commented Sep 25, 2024

TBH我感觉这个动态生成版本号的功能其实没啥必要,还造成了很多麻烦,希望能删除掉@Yuukiy

@glyh glyh requested a review from Yuukiy September 25, 2024 05:19
@cnzgray
Copy link
Contributor Author

cnzgray commented Sep 25, 2024

已经解决了Docker镜像构建后的版本问题

image

构建的镜像tag规则见:docker/metadata-action: GitHub Action to extract metadata (tags, labels) from Git reference and GitHub events for Docker

@glyh glyh merged commit 0540813 into Yuukiy:master Sep 25, 2024
3 checks passed
@cnzgray cnzgray deleted the feat/docker_support branch September 26, 2024 06:54
@glyh glyh removed the request for review from Yuukiy September 27, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants