[#471] Safely get line_number from PotentialSecret #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a relatively naive approach to solving the issue in Yelp#471. I looked at the PotentialSecret class and it very clearly has a default value of 0 for `line_number`. But alas, intermittently it does not. So this should safely fall back to 0 if `line_number` isn't present.
|
I'll review this one this weekend hopefully -- sorry for the delay. |
KevinHock
approved these changes
Aug 1, 2021
KevinHock
added a commit
that referenced
this pull request
Aug 1, 2021
PotentialSecret is not a dictionary, so do getattr and not .get Fixes #472
Merged
KevinHock
added a commit
that referenced
this pull request
Aug 1, 2021
|
Hey @js-truework, if you use the |
I'll check it out. It'll be hard to say definitively until I've been able to run it a bunch of times, since it was an intermittent bug to begin with. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively naive approach to solving the issue in #471. I looked at the PotentialSecret class and it very clearly has a default value of 0 for
line_number. But alas, intermittently it does not. So this should safely fall back to 0 ifline_numberisn't present.Closes #471 (I think)