↪️ Merge pull request #472 from js-truework/patch-1

[#471] Safely get line_number from PotentialSecret
Yelp · Aug 1, 2021 · a1ab77d · a1ab77d
2 parents b206dc2 + 64aee10
commit a1ab77d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/detect_secrets/core/secrets_collection.py b/detect_secrets/core/secrets_collection.py
@@ -213,8 +213,8 @@ def __iter__(self) -> Generator[Tuple[str, PotentialSecret], None, None]:
         for filename in sorted(self.files):
             secrets = self[filename]
 
-            # NOTE: If line numbers aren't supplied, they will default to 0.
-            for secret in sorted(secrets, key=lambda x: (x.line_number, x.secret_hash, x.type)):
+            # NOTE: If line numbers aren't supplied, they are supposed to default to 0.
+            for secret in sorted(secrets, key=lambda x: (x.get(line_number, 0), x.secret_hash, x.type)):
                 yield filename, secret
 
     def __bool__(self) -> bool: