Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method to get a dictionary of {user_pair:previous meeting count} #98

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

harshk360
Copy link
Contributor

  • Renamed get_previous_pair_meetings to get_previous_meetings
  • Moved get_previous_meetings (get_previous_pair_meetings) to a new match_utils.py file
  • Added a method to convert a list of user pairs to a dictionary of pairs to counts (for how many times they have met)
  • Added method to return a dictionary of {user_pair:previous meeting count} for a group of users to be matched
  • Created a new file group_match.py with the above method
  • group_match.py will hold the new group matching algorithm which will use the above method

@kentwills kentwills merged commit 8194ed1 into Yelp:master Jul 28, 2017
jeffrey-xiao added a commit to jeffrey-xiao/beans that referenced this pull request Jul 28, 2017
* 'master' of https://github.com/Yelp/beans:
  Save multiple participants for a meeting into db + refactoring (Yelp#100)
  method to get a dictionary of {user_pair:previous meeting count} (Yelp#98)
  downgrade react-router to v3.0.0 and a11y to v5.1.1 (Yelp#99)
  Revert eslint-plugin-jsx-a11y version to 5.1.1 to deal webpack errors (Yelp#97)
  Only disallow a pair if they matched earlier for the same subscription (Yelp#94)
  Devme (Yelp#92)
  Import PropTypes from prop-types package instead of react
  Created new module for matching. Renamed match.py to pair_match.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants