Save multiple participants for a meeting into db + refactoring #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshk360
force-pushed
the
feature/save_multiple_participants
branch
from
60eed5a to
33c955d
Compare
kentwills
approved these changes
Jul 28, 2017
jeffrey-xiao
added a commit
to jeffrey-xiao/beans
that referenced
this pull request
Jul 28, 2017
* 'master' of https://github.com/Yelp/beans: Save multiple participants for a meeting into db + refactoring (Yelp#100) method to get a dictionary of {user_pair:previous meeting count} (Yelp#98) downgrade react-router to v3.0.0 and a11y to v5.1.1 (Yelp#99) Revert eslint-plugin-jsx-a11y version to 5.1.1 to deal webpack errors (Yelp#97) Only disallow a pair if they matched earlier for the same subscription (Yelp#94) Devme (Yelp#92) Import PropTypes from prop-types package instead of react Created new module for matching. Renamed match.py to pair_match.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed save_pair_meetings to save_meetings
save_meetings now takes an additional parameter for number of participants in the meeting to be saved (this info can be parsed from the meeting. Should we do that?)
Some refactoring