all: improve EstimateGas API

[JukLee0ira]

Proposed changes

PR 20830 separate consensus errors and EVM Internal errors.Since EVM errors have already been separated in #200 , this PR will embed EVM errors into the executionResult structure, following the upstream code.

Test

Gas Consumption Comparison

Before this PR is merged:

• RPC: http://127.0.0.1:8545 – The changes from this PR are applied.
• RPC: https://rpc.apothem.network/ – The changes from this PR are not applied.

Request:

RPC="https://rpc.apothem.network"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 0,
  "method": "eth_estimateGas",
  "params": [
    {
      "from": "0xf366aa107A5Ed1d54AFDEA5506B3059Ce402Da28",
      "to": "0x53381ac6FE72C3cf469891F46248dc3dc02E8EA3",
      "data": "0xabcd012345"
    },
    "latest"
  ]}' | jq

Response:

{"jsonrpc":"2.0","id":0,"result":"0x535c"}

---

Request:

RPC="http://127.0.0.1:8545"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 0,
  "method": "eth_estimateGas",
  "params": [
    {
      "from": "0xf366aa107A5Ed1d54AFDEA5506B3059Ce402Da28",
      "to": "0x53381ac6FE72C3cf469891F46248dc3dc02E8EA3",
      "data": "0xabcd012345"
    },
    "latest"
  ]}' | jq

Response:

{"jsonrpc":"2.0","id":0,"result":"0x535c"}

Revert Logic Test

The following test contract was authored by @gzliudan ,originates from #200.

// SPDX-License-Identifier: MIT

pragma solidity ^0.6.0;

contract Test {
    uint256 private val;

    constructor() public {
        val = 1;
    }

    function getVal() public view returns (uint256) {
        return val;
    }

    function testRevert(bool willRevert) public view returns (uint256) {
        if (willRevert) {
            revert("I reverted");
        }

        return block.number;
    }

    function setVal(uint256 newValue) external {
        require(newValue < 10, "newValue >= 10");

        val = newValue;
    }
}

Request

RPC="http://127.0.0.1:8547"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 0,
  "method": "eth_estimateGas",
  "params": [
    {
      "to": "0xe8CECD75769Eda90bfFb9f0E4EFD086c543EF026",
      "data": "0x29d0bec00000000000000000000000000000000000000000000000000000000000000001",
      "value": "0x0"
    },
	"latest"
  ]}' | jq

Response

{
  "jsonrpc": "2.0",
  "id": 0,
  "error": {
    "code": -32000,
    "message": "always failing transaction (execution reverted) (I reverted)"
  }
}

---

Request

RPC="http://127.0.0.1:8547"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 0,
  "method": "eth_estimateGas",
  "params": [
    {
      "to": "0xe8CECD75769Eda90bfFb9f0E4EFD086c543EF026",
      "data": "0x3d4197f0000000000000000000000000000000000000000000000000000000000000000b",
      "value": "0x0"
    },
	"latest"
  ]}' | jq

Response

{
  "jsonrpc": "2.0",
  "id": 0,
  "error": {
    "code": -32000,
    "message": "always failing transaction (execution reverted) (newValue >= 10)"
  }
}

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement
• N/A

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[JukLee0ira]

Revert Logic Test have been added.