internal/ethapi: EstimateGas and Call handle revert error(#173) #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in current version XDPoSChain, it always return message:
if solidity contract function reverts when metamask or other client calls method
eth.estimateGas
. So the user and wallet software can not judge if revert will occur, and can not get the revert message when revert. This is the main problem which complained by xcantera in #173. This PR parse and return the revert message/reason for both of eth.call and eth.estimateGas. I have tested this PR in my private network, not in Apothem testnet, since I can not synchronize with Apothem testnet according to current document.Below is my test contract: