Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing include #7858

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix missing include #7858

merged 1 commit into from
Dec 20, 2023

Conversation

qberthet
Copy link
Contributor

Problem solved by the commit

Probably in the trail of #7841 , it seems that there is still a missing #include <cstdint>.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

While compiling XRT master on Alma9 with GCC 13.1.0 and CMake 3.27.5 (I know, unsupported os), I encountered the following error:

[ 56%] Building CXX object runtime_src/core/tools/xbmgmt2/CMakeFiles/xbmgmt2.dir/__/common/reports/ReportAiePartitions.cpp.o
In file included from /home/qberthet/devel/atlasexternals/XRT/src/runtime_src/core/tools/common/Process.cpp:37:
/home/qberthet/devel/atlasexternals/XRT/src/runtime_src/core/tools/common/EscapeCodes.h:26:22: error: expected ')' before '_color'
   26 |       fgcolor(uint8_t _color) : m_color(_color) {};
      |              ~       ^~~~~~~
      |                      )
/home/qberthet/devel/atlasexternals/XRT/src/runtime_src/core/tools/common/EscapeCodes.h:32:6: error: 'uint8_t' does not name a type
   32 |      uint8_t m_color;
      |      ^~~~~~~

How problem was solved, alternative solutions (if any) and why they were rejected

Added the missing include in EscapeCodes.h and compilation succeed.

@gbuildx
Copy link
Collaborator

gbuildx commented Dec 19, 2023

Can one of the admins verify this patch?

@chvamshi-xilinx
Copy link
Collaborator

ok to test

@gbuildx
Copy link
Collaborator

gbuildx commented Dec 19, 2023

Build Passed!

@stsoe
Copy link
Collaborator

stsoe commented Dec 19, 2023

Thank you @qberthet , please sign off the commit.

Signed-off-by: Quentin Berthet <quentin.berthet@cern.ch>
@qberthet qberthet force-pushed the fix_missing_include branch from c31807d to 1a66ec9 Compare December 20, 2023 09:17
@gbuildx
Copy link
Collaborator

gbuildx commented Dec 20, 2023

Build Passed!

@stsoe stsoe merged commit 065eb63 into Xilinx:master Dec 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants