-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing XRT issue for Ubuntu 23.10 #7841
Conversation
Signed-off-by: Homa Aghilinasab <haghilin@amd.com>
Hi @keryell, Thanks for reporting the issue |
src/runtime_src/core/pcie/emulation/hw_emu/alveo_shim/system_hwemu.h
Outdated
Show resolved
Hide resolved
src/runtime_src/core/pcie/emulation/sw_emu/generic_pcie_hal2/system_swemu.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Homa Aghilinasab <haghilin@amd.com>
Build failed :( |
retest this please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Build failed :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The compilation is good now.
Just remaining #7806 (comment)
retest this please! |
Build failed :( |
retest this please |
Build failed :( |
retest this please |
Signed-off-by: Homa Aghilinasab <haghilin@amd.com>
I have just tried and I still have
@mamin506 suggested me it might be in @jvillarre backyard. |
Build failed :( |
retest this please |
Build failed :( |
Signed-off-by: Homa Aghilinasab <haghilin@amd.com>
Build Passed! |
Could this fix be backported to 2022.x? |
@dirksavage88 You would probably need some other PRs too. |
@keryell not the latest XRT, but 2022.1/2022.2 when using ubuntu 22.04 (which should be supported?) on kernel 6.5. Please see the full debug output attachment here: #8093 The original issue with ubuntu 23.10 resulted in a build fail during xocl. I am experiencing a similar build fail but it occurs randomly in the build process. |
I was unclear. My question is : does the latest XRT from master branch works for you? |
master fails with this error: I am following the docs that say to use XRT version that matches the Vitis version (of which I am using Vitis 2022.1) |
Usually recent XRT works with older Vitis. But you could give a try to Vitis 2023.2. :-) |
Problem solved by the commit:
There was compilation issues on Ubuntu 23.10 which was reported in issue #7806.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
issue #7806
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary