Refactor: NpcNameFinder SearchMode.Fuzzy default for non corpse names and small improvements

Core/GoalsComponent/NpcNameTargeting.cs

@@ -170,7 +170,7 @@ public bool FindBy(params CursorType[] cursor)
         const int e = 3;
         Span<Point> attemptPoints = stackalloc Point[c + (c * e)];
 
-        for (int ni = 0; ni < npcNameFinder.Npcs.Length; ni++)
+        for (int ni = 0; ni < npcNameFinder.Npcs.Count; ni++)
         {
             NpcPosition npc = npcNameFinder.Npcs[ni];
             for (int i = 0; i < c; i += e)
@@ -204,7 +204,7 @@ public bool FindBy(params CursorType[] cursor)
 
     public void ShowClickPositions(Graphics gr)
     {
-        for (int i = 0; i < npcNameFinder.Npcs.Length; i++)
+        for (int i = 0; i < npcNameFinder.Npcs.Count; i++)
         {
             NpcPosition npc = npcNameFinder.Npcs[i];
             for (int j = 0; j < locFindBy.Length; j++)

CoreTests/CoreTests.csproj

@@ -5,6 +5,7 @@
     <TargetFramework>net7.0</TargetFramework>
     <Platforms>AnyCPU;x64;x86</Platforms>
     <ApplicationManifest>app.manifest</ApplicationManifest>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
   <ItemGroup>

CoreTests/NpcNameFinder/NpcNameOverlay.cs

@@ -27,7 +27,7 @@ public class NpcNameOverlay : IDisposable
     private readonly bool debugTargeting;
     private readonly bool debugSkinning;
 
-    private const int padding = 4;
+    private const int padding = 6;
     private const float NumberLeftPadding = 20f;
     private const int FontSize = 10;
 
@@ -115,7 +115,7 @@ private void DrawGraphics(object sender, DrawGraphicsEventArgs e)
 
         g.DrawRectangle(brush, npcNameFinder.Area.Left, npcNameFinder.Area.Top, npcNameFinder.Area.Right, npcNameFinder.Area.Bottom, 1);
 
-        for (int i = 0; i < npcNameFinder.Npcs.Length; i++)
+        for (int i = 0; i < npcNameFinder.Npcs.Count; i++)
         {
             NpcPosition npc = npcNameFinder.Npcs[i];
 

CoreTests/NpcNameFinder/Test_NpcNameFinder.cs

@@ -83,21 +83,25 @@ public void Dispose()
 
     public void Execute()
     {
-        if (LogEachUpdate)
-            stopwatch.Restart();
-
+        long captureTime = Stopwatch.GetTimestamp();
         wowScreen.Update();
 
         if (LogEachUpdate)
-            logger.LogInformation($"Capture: {stopwatch.ElapsedMilliseconds}ms");
-
-        if (LogEachUpdate)
-            stopwatch.Restart();
+        {
+            stringBuilder.Length = 0;
+            stringBuilder.Append($"Capture: {Stopwatch.GetElapsedTime(captureTime).TotalMilliseconds:F6}ms");
+        }
 
+        long updateTime = Stopwatch.GetTimestamp();
         npcNameFinder.Update();
 
         if (LogEachUpdate)
-            logger.LogInformation($"Update: {stopwatch.ElapsedMilliseconds}ms");
+        {
+            stringBuilder.Append(" | ");
+            stringBuilder.Append($"Update: {Stopwatch.GetElapsedTime(updateTime).TotalMilliseconds:F6}ms");
+
+            logger.LogInformation(stringBuilder.ToString());
+        }
 
         if (saveImage)
         {

SharedLib/Extensions/PointExt.cs

@@ -1,7 +1,5 @@
 using System.Drawing;
 
-using static System.MathF;
-
 namespace SharedLib.Extensions;
 
 public static class PointExt
@@ -18,6 +16,6 @@ public static Point Scale(this Point p, float scaleX, float scaleY)
 
     public static float SqrDistance(in Point p1, in Point p2)
     {
-        return Sqrt(((p1.X - p2.X) * (p1.X - p2.X)) + ((p1.Y - p2.Y) * (p1.Y - p2.Y)));
+        return ((p1.X - p2.X) * (p1.X - p2.X)) + ((p1.Y - p2.Y) * (p1.Y - p2.Y));
     }
 }

SharedLib/NpcFinder/LineSegment.cs

@@ -7,11 +7,11 @@ public readonly struct LineSegment
     public readonly int XEnd;
     public readonly int XCenter;
 
-    public LineSegment(int xStart, int xend, int y)
+    public LineSegment(int xStart, int xEnd, int y)
     {
         this.XStart = xStart;
         this.Y = y;
-        this.XEnd = xend;
+        this.XEnd = xEnd;
         XCenter = XStart + ((XEnd - XStart) / 2);
     }
 }