Refactor: NpcNameFinder SearchMode.Fuzzy default for non corpse names and small improvements
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons. Beside Corpse type npc names use SearchMode.Fuzzy for better results. Corpse names(rgb=128) shade are too common, need to find a better way to distingush. Upon DetermineNpcs no longer allocating extra array for the result. Improved FuzzyColor comparison by avoiding Sqrt calculation.
…etter use of stopwatch and stringbuilder for the output.
Xian55
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Wrath classic PTR there's a new accessibility feature which allows to adjust the minimum size of the Npc names.
The recommended
Minimum Character Name Sizevalue is 6 or 8 for 1920x1080 resolution.This greatly helps a NpcNameFinder component! There's one challenge what needs to be tackled meanwhile. As soon as the
Minimum Character Name Sizeis changed from 0 there are some distance based alpha blending going on.So
SearchMode.Simpleyields really poor results, only works in really close range. HoweverSearchMode.Fuzzymode allows to detect shades of that given color. It works really well with friendly(green), neutral(yellow) and enemies(red).For Corpse(grey / RGB=128) type names however, it's a more trickier situation since that shade is way too common in the game so for now
SearchMode.Simplemode is used for this case.