Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments #2591

Conversation

anton-vlasenko
Copy link

@anton-vlasenko anton-vlasenko commented Apr 14, 2022

Trac ticket: https://core.trac.wordpress.org/ticket/55574

Steps to test this PR: https://core.trac.wordpress.org/ticket/55574#comment:2

This PR is a follow-up to #2488 (review)


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@anton-vlasenko anton-vlasenko changed the title WP_REST_Pattern_Directory_Controller must not concatenate slug values WP_REST_Pattern_Directory_Controller must not use implode to concatenate slug values Apr 14, 2022
@anton-vlasenko anton-vlasenko changed the title WP_REST_Pattern_Directory_Controller must not use implode to concatenate slug values WP_REST_Pattern_Directory_Controller must not use implode to concatenate slug values Apr 14, 2022
@anton-vlasenko anton-vlasenko changed the title WP_REST_Pattern_Directory_Controller must not use implode to concatenate slug values WP_REST_Pattern_Directory_Controller::get_items doesn't support array arguments Apr 14, 2022
@gziolo
Copy link
Member

gziolo commented Apr 19, 2022

Committed with https://core.trac.wordpress.org/changeset/53218.

@gziolo gziolo closed this Apr 19, 2022
anton-vlasenko added a commit to WordPress/gutenberg that referenced this pull request May 5, 2022
gziolo pushed a commit to WordPress/gutenberg that referenced this pull request Jun 30, 2022
…ay arguments (#40900)

* Backport WordPress/wordpress-develop#2591 to Gutenberg.

* Backport WordPress/wordpress-develop#2625 to Gutenberg.

* Update PHPDoc block.

* Fix comments

* Replace WP with WordPress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants