Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for wp/v2/block-patterns/patterns and /wp/v2/pattern-directory/patterns endpoints to Gutenberg #40824

Closed
1 of 3 tasks
anton-vlasenko opened this issue May 4, 2022 · 4 comments · Fixed by #40900 or #40902
Assignees
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced

Comments

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented May 4, 2022

What problem does this address?

There have been 3 Core PRs that fixed a number of issues related to wp/v2/block-patterns/patterns and /wp/v2/pattern-directory/patterns endpoints.
These PRs have to be backported back to Gutenberg:

@anton-vlasenko anton-vlasenko self-assigned this May 4, 2022
@anton-vlasenko anton-vlasenko added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label May 4, 2022
@gziolo gziolo added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label May 4, 2022
@ndiego
Copy link
Member

ndiego commented Jun 2, 2022

@gziolo looking for some guidance here. This issue and the associated PRs backport some last-minute changes that made it into 6.0. These changes were never added back to Gutenberg itself. I am about to put together a PR that fixes #41282 but it relies on the PRs associated with this issue being backported. I cannot think of a reason we wouldn't want to backport these to Gutenberg, unless I am missing something. Thanks for your insight 🙏

@gziolo
Copy link
Member

gziolo commented Jun 14, 2022

Yes, we definitely should bring back all those changes to the Gutenberg plugin. @ndiego, I had some time off so I haven't seen your message earlier. We always bring back to the plugin all changes applied in WordPress core in case we have matching functionality for previous versions of WordPress.

@ndiego
Copy link
Member

ndiego commented Jun 16, 2022

@gziolo no worries, hope you enjoyed your time off!

@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Jun 23, 2022

I'm reopening this issue because #40900 is not merged yet.
GitHub automatically closed this issue, but it should remain open until #40900 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced
Projects
None yet
3 participants