-
Notifications
You must be signed in to change notification settings - Fork 117
Style the Latest Posts block to match the comps #153
Conversation
Overall this looks good to me. I only have 1 reservation... What happens if the post-author selects a dark background color? Would it not be simpler if the border-color was set to |
It is the color of the text by default, but isn't the purpose of using a CSS variable that these two can be set to two different colors? |
Yes, I was just referring to some hardcoded instances of the |
I think that's just in the IE stylesheet. All the variables are converted to static values there. |
Ah you're absolutely right! I somehow missed that 👍 |
I've migrated this item over to be a Gutenberg fix, since it's something that happens by default everywhere: WordPress/gutenberg#25688 |
Looking great so far 👍 Can we figure out a css masonry solution for tiling the Grid + Borders style, or use a flex property so each row of items is the same height? |
Yeah, I'm taking a look at that. I figured a simple |
@melchoyce should be fixed in that last commit. If this fixes the issue for now and makes each row the same height, I'm happy pushing this for now and following up on the masonry layout later if we can figure it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on my end, too! Let's merge & iterate.
Closes #76.
Implements the three Latest Posts block styles as described in #76 (comment).
The screenshots below really showcase how
border
doesn't work for multi-line links at the moment, but that's a separate issue. 😄Still to do:
Default
Dividers
Borders