Remove the right margin for the right-most list items in the lastest posts block #25688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Block] Latest Posts
2 tasks
|
Size Change: +84 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Sep 29, 2020
Yeah, I agree. This is a decent step forward in the meantime though. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this while building the Latest Posts block's theme styles for Twenty Twenty: WordPress/twentytwentyone#153.
Currently, the Latest Posts block's grid mode includes a right-margin declaration for the right-most items in the grid. This causes all items to be slightly off to the left:
This PR adds an additional style to remove the right-margin from that item. It also re-adjusts the width of each item to account for the change:
I tested in Twenty Twenty and Twenty Nineteen, and didn't see any issues. The width changes didn't seem to be picked up in the editor for Twenty because of the theme's more specific styles. But it didn't cause any issues there, and it looked great on the front end.