-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
@richtabor @scruffian what do you think? |
Related: WordPress/gutenberg#49279 (comment) |
We could also use things like: |
Maybe "body" and "heading" font works better; so variations can register different fonts and they're hooked up as expected. |
I think a variation of paragraph could work as well, are we overdoing it with all the block styles? |
I don't think we're overdoing it, but I'm a bit hesitant adding a style to such a prominent block. We can try it in a quick PR, but I'm not sure it's necessary. |
@richtabor I gave it a try here and I was sadly surprised that you can only change styles via theme.json to default variations and not theme created ones. |
This should do the trick: #367 |
Makes sure they work across variations
Let's focus on the first variation before doing all the others. |
I made some adjustments, focusing on color application. Notably:
Notice how the duotone works for both: CleanShot.2023-09-14.at.14.40.00.mp4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as an initial push. We'll want to circle back with font family adjustments, but let's merge this before potential conflicts.
Description
Closes #10
This PR creates the 3 style variations. We have a problem with the way we've built patterns, and some of them apply a specific font family to the markup, making the block styles inconsistent. I don't know if we can fix all of them (in some cases we are applying the Cardo font family to paragraphs so they look like they are headings when they are not).
My first instinct is to create a custom variable called heading font and another called base font or something like that, to use them in patterns and then map them in theme.json. This would be the perfect opportunity for refs to work on block markup.
EDIT: This PR paired with #366 should cover the patterns too