Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow styling blocks inside template parts with theme.json #43347

Open
carolinan opened this issue Aug 18, 2022 · 4 comments · May be fixed by #44126
Open

Allow styling blocks inside template parts with theme.json #43347

carolinan opened this issue Aug 18, 2022 · 4 comments · May be fixed by #44126
Assignees
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

What problem does this address?

As contributors are starting to submit style variations for Twenty Twenty-Three, it is becoming more apparent how limiting it is to not be able to style the site header and site footer using theme.json.

Because the template part has no block supports for colors, spacing etc, and all styles are on the inner blocks, these two areas can't be updated with style variations.

What is your proposed solution?

There should be a way to style blocks inside the default template part areas.
Just like we can use styles.blocks.blockname, we should be able to target blocks one "layer" down using
styles.templatePart.templatepart-name.blockname, or perhaps
styles.templatePart.area.footer.blockname.

@carolinan
Copy link
Contributor Author

Closing in favor of #40318.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 13, 2022
@matiasbenedetto
Copy link
Contributor

I worked on a quick experiment yesterday: #44126
Re-opening this issue to discuss if this is still something useful or not.

@carolinan
Copy link
Contributor Author

carolinan commented Sep 13, 2022

As far as I understood, the deadline for including enhancements in 6.1 has already passed.

@WraithKenny
Copy link

I'd settle for being able to style things like colors or fonts in the footer, but not the header, which seems impossible currently, unless I'm missing something?

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 1, 2023
@jordesign jordesign changed the title Styling blocks inside template parts with theme.json Allow styling blocks inside template parts with theme.json Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants