Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename object-caching to object-cache #108

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Rename object-caching to object-cache #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1eab66
rename `object-caching` to `object-cache`
tillkruss Jan 19, 2022
beb3ed0
the worst code standard of all 😡
tillkruss Jan 19, 2022
7df9c9b
fix formatting
tillkruss Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
/tests/modules/javascript @aristath @gziolo
/tests/testdata/modules/javascript @aristath @gziolo

# Focus: Object Caching
/modules/object-caching @tillkruss @dustinrue
/tests/modules/object-caching @tillkruss @dustinrue
/tests/testdata/modules/object-caching @tillkruss @dustinrue
# Focus: Object Cache
/modules/object-cache @tillkruss @spacedmonkey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - let's make sure to also update this elsewhere though, e.g. the GitHub label and our focus area organization spreadsheet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already updated the labels and project in the repo. @bethanylang Where else would this need updating?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tillkruss Just the focus spreadsheet; updated here: https://docs.google.com/spreadsheets/d/16N5oZ9wE6AkiqMz7b_707eh24vvpjMwsEG67XFAbxy8/edit#gid=0.

/tests/modules/object-cache @tillkruss @spacedmonkey
/tests/testdata/modules/object-cache @tillkruss @spacedmonkey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with this change just a little more until we've confirmed. If/once we merge this, we also need to update e.g. the spreadsheet with our PoCs accordingly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confirmed.

Screen Shot 2022-01-25 at 8 49 57 AM


# Focus: Measurement
/modules/measurement @AymenLoukil @josephscott
Expand Down
12 changes: 6 additions & 6 deletions admin/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,20 +167,20 @@ function perflab_render_modules_page_field( $module_slug, $module_data, $module_
*/
function perflab_get_focus_areas() {
return array(
'images' => array(
'images' => array(
'name' => __( 'Images', 'performance-lab' ),
),
'javascript' => array(
'javascript' => array(
'name' => __( 'JavaScript', 'performance-lab' ),
),
'site-health' => array(
'site-health' => array(
'name' => __( 'Site Health', 'performance-lab' ),
),
'measurement' => array(
'measurement' => array(
'name' => __( 'Measurement', 'performance-lab' ),
),
'object-caching' => array(
'name' => __( 'Object caching', 'performance-lab' ),
'object-cache' => array(
'name' => __( 'Object Cache', 'performance-lab' ),
),
);
}
Expand Down
14 changes: 7 additions & 7 deletions tests/admin/load-tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,20 @@ class Admin_Load_Tests extends WP_UnitTestCase {
);

private static $demo_focus_areas = array(
'images' => array(
'images' => array(
'name' => 'Images',
),
'javascript' => array(
'javascript' => array(
'name' => 'JavaScript',
),
'site-health' => array(
'site-health' => array(
'name' => 'Site Health',
),
'measurement' => array(
'measurement' => array(
'name' => 'Measurement',
),
'object-caching' => array(
'name' => 'Object caching',
'object-cache' => array(
'name' => 'Object Cache',
),
);

Expand Down Expand Up @@ -181,7 +181,7 @@ public function test_perflab_get_focus_areas() {
'javascript',
'site-health',
'measurement',
'object-caching',
'object-cache',
);
$this->assertSame( $expected_focus_areas, array_keys( perflab_get_focus_areas() ) );
}
Expand Down