-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename object-caching
to object-cache
#108
Conversation
for consistency with WordPress core; add @spacedmonkey as code owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I'd prefer if we can hold off a few more days with merging this - see my comments below.
# Focus: Object Cache | ||
/modules/object-cache @tillkruss @spacedmonkey | ||
/tests/modules/object-cache @tillkruss @spacedmonkey | ||
/tests/testdata/modules/object-cache @tillkruss @spacedmonkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait with this change just a little more until we've confirmed. If/once we merge this, we also need to update e.g. the spreadsheet with our PoCs accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/tests/modules/object-caching @tillkruss @dustinrue | ||
/tests/testdata/modules/object-caching @tillkruss @dustinrue | ||
# Focus: Object Cache | ||
/modules/object-cache @tillkruss @spacedmonkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 - let's make sure to also update this elsewhere though, e.g. the GitHub label and our focus area organization spreadsheet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already updated the labels and project in the repo. @bethanylang Where else would this need updating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tillkruss Just the focus spreadsheet; updated here: https://docs.google.com/spreadsheets/d/16N5oZ9wE6AkiqMz7b_707eh24vvpjMwsEG67XFAbxy8/edit#gid=0.
Excellent, updated the focus area name in the spreadsheet now as well. |
Summary
WordPress core calls it "Object Cache" not "Object Caching".
Also replaced @dustinrue with @spacedmonkey as code owner, if that's cool?
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.