Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update home link screen reader text #788

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Update home link screen reader text #788

merged 2 commits into from
Mar 8, 2023

Conversation

zackkrida
Copy link
Member

Fixes

Related to #448

Description

Updates the text for screen readers from "Home" to "Openverse Home" on the header logo link.

Testing Instructions

Test Openverse using a screen reader and verify the correct text is read out. Also inspect the html and view the "Openverse home" text.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner February 28, 2023 14:03
@zackkrida zackkrida requested review from krysal and stacimc February 28, 2023 14:03
@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature ♿️ aspect: a11y Concerns related to the project's accessibility 🧱 stack: frontend Related to the Nuxt frontend labels Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/788

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@github-actions
Copy link

Playwright failure test results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for all playwright tests that have failed at the bottom of this page, under the
"Artifacts" section:

https://github.com/WordPress/openverse/actions/runs/4294105790

Read more about how to use this artifact here: https://github.com/WordPress/openverse/blob/main/frontend/test/playwright/README.md#debugging

@obulat obulat requested review from obulat and removed request for stacimc March 1, 2023 04:41
@openverse-bot
Copy link
Collaborator

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@krysal
@obulat
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2.

@zackkrida, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@@ -84,7 +84,9 @@ test.describe("Header internal", () => {
const homeUrl = page.url()
await clickMenuButton(page)
await page.getByRole("link", { name: t("navigation.about") }).click()
await page.getByRole("link", { name: t("header.home-link") }).click()
// "Openverse Home" is hardcoded because our translation helper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice explanation!

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@obulat obulat merged commit b8e294b into main Mar 8, 2023
@obulat obulat deleted the adjust-home-link-title branch March 8, 2023 02:50
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants