-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update home link screen reader text #788
Conversation
Full-stack documentation: Ready https://WordPress.github.io/openverse/_preview/788 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Playwright failure test results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse/actions/runs/4294105790 Read more about how to use this artifact here: https://github.com/WordPress/openverse/blob/main/frontend/test/playwright/README.md#debugging |
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @krysal Excluding weekend1 days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @zackkrida, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
@@ -84,7 +84,9 @@ test.describe("Header internal", () => { | |||
const homeUrl = page.url() | |||
await clickMenuButton(page) | |||
await page.getByRole("link", { name: t("navigation.about") }).click() | |||
await page.getByRole("link", { name: t("header.home-link") }).click() | |||
// "Openverse Home" is hardcoded because our translation helper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice explanation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes
Related to #448
Description
Updates the text for screen readers from "Home" to "Openverse Home" on the header logo link.
Testing Instructions
Test Openverse using a screen reader and verify the correct text is read out. Also inspect the html and view the "Openverse home" text.
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin