-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility with Windows screen readers tracking issue for home/search results pages #448
Comments
Please feel free to create follow-ups, I know this is likely way too big to be actionable. Just wanted to provide a good starting point. |
@zackkrida wanted to give you in particular a heads up here! Thanks so much for opening this, Alex. |
@alexstine, thank you so much for reaching out and compiling this huge issue! We have tried to implement the new design in an accessible way, but your issue clearly shows that we need to collaborate with the accessibility teams more. I have started creating follow-up issues and need some clarifications for the following two points.
I tried using NVDA on openverse.org. Currently, when I open the homepage, and click D, I get to the "main" landmark. Then, when I click "Shift" plus "D" to go back, I hear "Banner landmark home visited link current page." Should there be a different behavior?
We have the logo with the name of the site that is currently the first element in the banner landmark. Its label is "home" because that's what we saw on other sites. Do you suggest that the label should actually be "Openverse home"? Or "Openverse"? Should it be the same on all pages, or should the homepage logo label be different? Do you have examples of websites with good accessibility? I look at other sites for examples, but I'm not sure if they are good or not. By the way, the search page has the "Skip to content" link, but we didn't add it to other pages. That was an oversight. |
@zackkrida Answers.
This is actually okay. Now that I know Home is not supposed to be a navigation item, this makes sense.
I would change the "Home" screen reader text to "Openverse Home". Just a slight adjustment there helps users keep context. Thanks. |
For this one: what's the best way to give context for this? Is it sufficient to add the type of result in the link title (e.g. "Image result: ")? Thanks for taking the time to write up this issue. |
@sarayourfriend I think the "Image:", "Audio":, or "Video:" prefixes work fine. It is already clear that the items the user is viewing are results, just need to tell them what they are. |
Perfect, thanks, Alex. I've cut an issue for it here: #1010 |
We are going to close this issue as the remaining issues can be tracked using the separate issues, and they require design input. |
Description
Tracking issue for accessibility fixes for Windows screen readers on the home/search results pages.
Issues
h1
openverse-frontend#2176footer
insidemain
openverse-frontend#2179Quote 1
Quote 2
Code snippet 1
Problem:
Solution:
The screen reader text is okay but the issue is, the spacing is not retained. It comes out reading like this.
The other easy solution is to insert a space before the closing
</span>
but this is not always guaranteed to work.Environment
The text was updated successfully, but these errors were encountered: