Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search results to an ordered list #794

Closed
zackkrida opened this issue Feb 28, 2023 · 2 comments · Fixed by #1979
Closed

Move search results to an ordered list #794

zackkrida opened this issue Feb 28, 2023 · 2 comments · Fixed by #1979
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

zackkrida commented Feb 28, 2023 •
edited
Loading

Openverse search results should be wrapped in an ordered list and li element for each returned result. This will help screen reader users identify the number of results returned and their current position in the results.
@zackkrida zackkrida mentioned this issue Feb 28, 2023
Closed
15 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 28, 2023
@zackkrida zackkrida changed the title Follow-up from the above point, it would be nice if these links appeared in a list, ul/li elements. It is impossible to know as a screen reader user how many links are there at any given time. Move search results to an unordered list Feb 28, 2023
@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility 🧱 stack: frontend Related to the Nuxt frontend labels Feb 28, 2023
@dhruvkb
Copy link
Member

dhruvkb commented Feb 28, 2023 •
edited
Loading

@zackkrida why unordered? Assuming we are sorting results by relevance (or in the future, an option to sort by indexed_on) the order of the results is meaningful information; so <ol> would be more appropriate imo.

@zackkrida
Copy link
Member Author

@dhruvkb 👍 you're right. I use ordered lists so infrequently in HTML that I didn't even consider it.

@zackkrida zackkrida changed the title Move search results to an unordered list Move search results to an ordered list Feb 28, 2023
@obulat obulat mentioned this issue May 2, 2023
Merged
8 tasks
@obulat obulat moved this from 📋 Backlog to 🏗 In progress in Openverse Backlog May 2, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Openverse Backlog May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use contentlist role for search results for a11y WordPress/openverse
2 participants
@zackkrida @dhruvkb