Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New spacings in Switcher item component #631

Closed
fcoveram opened this issue Jan 19, 2022 · 1 comment
Closed

New spacings in Switcher item component #631

fcoveram opened this issue Jan 19, 2022 · 1 comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@fcoveram
Copy link
Contributor

Description

The Switcher item component is now a single component that includes the desktop and mobile versions.

The component has new internal spacings for the Medium size; it changed from 24px to 16px to look less intrusive on search results and match the homepage use. The Small size does not have any change.

CleanShot 2022-01-19 at 10 06 29@2x

Additional context

This change impacts tickets WordPress/openverse-frontend#613 and WordPress/openverse-frontend#637
@fcoveram fcoveram added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Jan 19, 2022
This was referenced Jan 19, 2022
Merged
Merged
This was referenced Jan 21, 2022
Closed
Merged
@obulat
Copy link
Contributor

obulat commented Feb 15, 2022

I believe this issue can now be closed, @panchovm ?

@obulat obulat mentioned this issue Feb 17, 2022
Merged
7 tasks
@obulat obulat added 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository labels Mar 18, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcoveram @obulat