This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Add 'beta' VPill to Audio in the content switcher #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content switcher item has inconsistent paddings on the left and right. I noticed the SVG element has margins that make the element bigger. The component has new spacings to make the switcher popover less intrusive, check the WordPress/openverse#631 ticket. On the other hand, I do not see the hover style of the other elements. Screenshot |
Looks like the margin issues are the main thing that need to be fixed. Once the sizing is correct this will be a quick approval! |
Align beta VPill on mobile and desktop
66333af
to
bca938f
Compare
zackkrida
reviewed
Jan 21, 2022
However, it looks like the 'beta' VPill is now missing! |
zackkrida
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the beta pill, and it looks fine ✅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🕹 aspect: interface
Concerns end-users' experience with the software
🌟 goal: addition
Addition of new feature
🟧 priority: high
Stalls work on the project or its dependents
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related #631 by @panchovm
Description
This PR adds constants for media type statuses (
supported
for images and all media,beta
for audio, andadditional
for video), and displays theBETA
VPill
to the right of Audio in content switcher dropdown (popover, modal).Testing Instructions
Run the app and click on the content switcher button in the header. You should see a yellow 'Beta' pill to the right of 'Audio'.
This PR is based on the 'add/pill-component' branch, so it contains a lot of unrelated changes, and I will clean it up after that PR is merged.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin