Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add 'beta' VPill to Audio in the content switcher #637

Merged
merged 15 commits into from
Jan 21, 2022
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 19, 2022

Fixes

Related #631 by @panchovm

Description

This PR adds constants for media type statuses (supported for images and all media, beta for audio, and additional for video), and displays the BETA VPill to the right of Audio in content switcher dropdown (popover, modal).

Testing Instructions

Run the app and click on the content switcher button in the header. You should see a yellow 'Beta' pill to the right of 'Audio'.

This PR is based on the 'add/pill-component' branch, so it contains a lot of unrelated changes, and I will clean it up after that PR is merged.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Jan 19, 2022
@obulat obulat added this to the Redesign milestone Jan 19, 2022
@obulat obulat requested a review from a team as a code owner January 19, 2022 06:57
@obulat obulat requested review from krysal and dhruvkb and removed request for a team January 19, 2022 06:57
@obulat obulat self-assigned this Jan 19, 2022
Base automatically changed from add/pill-component to main January 19, 2022 12:56
@fcoveram
Copy link

The content switcher item has inconsistent paddings on the left and right. I noticed the SVG element has margins that make the element bigger. The component has new spacings to make the switcher popover less intrusive, check the WordPress/openverse#631 ticket.

On the other hand, I do not see the hover style of the other elements.

Screenshot

CleanShot 2022-01-19 at 10 17 37@2x

@zackkrida
Copy link
Member

Looks like the margin issues are the main thing that need to be fixed. Once the sizing is correct this will be a quick approval!

@zackkrida zackkrida changed the base branch from main to add/redesigned-filterbar January 21, 2022 01:33
@zackkrida zackkrida changed the base branch from add/redesigned-filterbar to main January 21, 2022 01:33
@obulat
Copy link
Contributor Author

obulat commented Jan 21, 2022

@panchovm , could you please look at the latest version:
Screen Shot 2022-01-21 at 12 46 25 PM
There is about 2px of safe area around the svg icon itself, and then there is 8 px of margin inside the gray area, and 8px of outer padding from the Item Group.

@fcoveram
Copy link

I'm still seeing inconsistent spacings. Here is attached a gif from the Releases file showing the internal spacings of the popover.

@obulat
Copy link
Contributor Author

obulat commented Jan 21, 2022

Mobile switcher

(tabbing currently doesn't work, so you can only see the pink outline on focus by manually setting focus-visible in developer tools):
Screen Shot 2022-01-21 at 9 09 12 PM
All content is hovered, and images is focused using tab (simulated, as real tab doesn't work)

Desktop switcher

content-switcher

@obulat
Copy link
Contributor Author

obulat commented Jan 21, 2022

Setting it to py-2 seems to fix it:
content-switcher

@zackkrida zackkrida closed this Jan 21, 2022
@zackkrida zackkrida reopened this Jan 21, 2022
@zackkrida
Copy link
Member

However, it looks like the 'beta' VPill is now missing!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the beta pill, and it looks fine ✅

@zackkrida zackkrida merged commit 4aeb9fd into main Jan 21, 2022
@zackkrida zackkrida deleted the add/audio_pill branch January 21, 2022 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants