Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add stories for the content type switcher #665

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Add stories for the content type switcher #665

merged 1 commit into from
Jan 21, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jan 21, 2022

Description

This PR adds a story for the VContentSwitcher component. This should make it easier to develop WordPress/openverse#631 in isolation.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Jan 21, 2022
@dhruvkb dhruvkb requested a review from a team as a code owner January 21, 2022 07:46
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting an individual item doesn't work. Applying the suggested change should fix it 🙂

I noticed a bug with the content switcher while testing this... closeMenu isn't used at all. I think it also indicates something wrong with the VPopover component, that we have to programatically close the popover when selecting an item...

@dhruvkb
Copy link
Member Author

dhruvkb commented Jan 21, 2022

Thanks, I'll update it. My idea was to keep the story simple, allowing the select event to be sent to the Actions tab instead of handling it.

@sarayourfriend
Copy link
Contributor

Ohhh, I wasn't even aware of what that actions tab did! Feel free to ignore my suggestion then.

@zackkrida
Copy link
Member

wasn't even aware of what that actions tab did

Same. TIL 😊

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvkb dhruvkb merged commit 375fc6e into main Jan 21, 2022
@dhruvkb dhruvkb deleted the content_stories branch January 21, 2022 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants