-
Notifications
You must be signed in to change notification settings - Fork 63
Show a generated artwork when the audio thumbnail is absent #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flawless execution. So great. You simplified the p5 code and documented the new mathematical functions so clearly 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! So creative, I really admire how you solved this!!!
I tested it locally and it works great. I tried to do some light performance testing by throwing 20 of them into the story and visiting the non-iframe version of the story on a low-power android device. There was a slight difference between loading only one and loading 20 and I tried several times for each one to make sure I wasn't perceiving slowness or just hitting a bump in the network... I think it is fine. If there really is a difference then it is miniscule.
Anyway, really great work, such a cool solution 😀
I had a couple of mathematical computing courses in college. Really came in handy today! |
* Update figma links in README * Search results title (#577) * Fix ci tests by restoring scopedSlots param in search results title spec * Fix search result title casing * Updated load more button (#578) * Update `content-types` test with load more button changes * VHeader (#488) * Add VHeader stub Rename VSearchBar and VSearchButton and move to VHeader Add VLogoLoader to VHeader and adjust header styles * Extract search route handling into composable, set Logo loading when fetching * Update pnpm lockfile * Add VFilterButton (#489) Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Zack Krida <zackkrida@pm.me> * Add searchbar to header (#491) Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Zack Krida <zackkrida@pm.me> * Update references to `InputField` to point to `VInputField` (#586) * New 404 page (#583) Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com> Co-authored-by: Zack Krida <zackkrida@pm.me> Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com> Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com> * Fix video tab The media store query.mediaType is null for video, so it's not possible to use it as a key to look up results in the store * Fix filters e2e tests by opening the sidebar * Fix openverse.pot after-merge problems * Fix e2e tests * Show a generated artwork when the audio thumbnail is absent (#600) * Fix single result back links * Fix photo detail test * Fix photo-details test * Combine layouts into a single default (#599) * Add header icons (#604) * Fix error when `<rect>` dimensions are negative (#605) * Add `VContentLink` component (#560) Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Olga Bulat <obulat@gmail.com> * Prevent unsupported media types causing header errors * Better video tab fix * Remove sample audio data (#571) Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve> Co-authored-by: Olga Bulat <obulat@gmail.com> Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com> Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
* Update figma links in README * Search results title (#577) * Fix ci tests by restoring scopedSlots param in search results title spec * Fix search result title casing * Updated load more button (#578) * Update `content-types` test with load more button changes * VHeader (#488) * Add VHeader stub Rename VSearchBar and VSearchButton and move to VHeader Add VLogoLoader to VHeader and adjust header styles * Extract search route handling into composable, set Logo loading when fetching * Update pnpm lockfile * Add VFilterButton (#489) Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Zack Krida <zackkrida@pm.me> * Add searchbar to header (#491) Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Zack Krida <zackkrida@pm.me> * Update references to `InputField` to point to `VInputField` (#586) * New 404 page (#583) Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com> Co-authored-by: Zack Krida <zackkrida@pm.me> Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com> Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com> * Fix video tab The media store query.mediaType is null for video, so it's not possible to use it as a key to look up results in the store * Fix filters e2e tests by opening the sidebar * Fix openverse.pot after-merge problems * Fix e2e tests * Show a generated artwork when the audio thumbnail is absent (#600) * Fix single result back links * Fix photo detail test * Fix photo-details test * Combine layouts into a single default (#599) * Add header icons (#604) * Fix error when `<rect>` dimensions are negative (#605) * Default to all from the homepage; init * Add `VContentLink` component (#560) Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Olga Bulat <obulat@gmail.com> * Prevent unsupported media types causing header errors * Better video tab fix * Fix homepage test * Remove sample audio data (#571) * Modify "fetchState" mutations to support ALL_MEDIA * All_MEDIA state working except for SET_MEDIA * all media state init * UI suppoort for media count * wip * ugh * Mobile box layout adjustments * Fix image clicks * Content links * Add debugging comment * Remove dead code * Result rounded corners * Update src/utils/srand.js * Focus states * Small styling improvements to image grid title and horizontal spacing * Refactor fetching for all media (#621) * Refactor all fetching to use getters more * Disable failing tests * Revert index/key rename in image cell v-for Co-authored-by: Zack Krida <zackkrida@pm.me> * Add a wrapper to FETCH_MEDIA to simplify fetching all content (#640) Add a wrapper to FETCH_MEDIA to simplify fetching all content * Double number of skeleton boxes * Progress * Remove unused filter display component * Set query when using filters * Fix tests * truncate audio box text Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve> Co-authored-by: Olga Bulat <obulat@gmail.com> Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com> Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com> Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
Fixes
Fixes #349 by @zackkrida
Description
This PR adds the code for generating the album art when the audio artwork does not exist or if the image raises an error. It also adds the 'V-' prefix to the component name.
Testing Instructions
VAudioThumbnail
stories and docs.Screenshots
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin