Add VContentLink component

[krysal]

Fixes

Fixes #453 by @panchovm

Description

This PR adds the mobile version of the Content Link component.

Testing Instructions

Run pnpm storybook and try its interactions.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[obulat]

We should probably extract this resultsCountLabel function in the future, because it's used in the search bar as well.

[krysal]

I extracted it into a new use-i18n-utilities.js composable and tried to replace the code on the VHeader but seems not to work well within watchEffect, I couldn't make it work there.

[zackkrida]

Looks great, but should the desktop version be included here too? Maybe instead of looking at is as desktop vs. mobile it should be prop-based, like 'stacked' vs. 'horizontal' with a layout prop?

[fcoveram]

It looks great 🎉

Just one comment. I noticed it says Image instead of Images. It should have the S at the end of Image, not in Audio.

To @zackkrida's comment. I would add the version when filter sidebar is expanded and the element slightly reduces its width.

[krysal]

@zackkrida I like that approach! In my mind, I was overcomplicating it with breakpoints. I'd add the desktop version too.

@panchovm Good catch, thanks, I'll fix it. Also, are you referring to this component?

I think that @obulat is developing that in #568 (not sure). If not, it will probably be another component anyway, called VContentTypeMenu or something like that. I see how they are closely related and I can work on it after this.

[zackkrida]

@krysal The desktop version is actually used on the "All" results page, above the results:

Figma: https://www.figma.com/file/w60dl1XPUvSaRncv1Utmnb/Openverse-Releases?node-id=133%3A22596

[zackkrida]

This looks really nice! I can implement this in the actual user interface in my image and all grid pull requests.

[sarayourfriend]

LGTM! Just a couple questions, non of which are blocking or even necessarily include specific suggestions for changes. Feel free to ignore them or we can push them off to a later day to solve later 🙂

Good work! The component looks good and the implementation is really nice.

[sarayourfriend]

It's a shame we have changes other than just organization that get tied to this (like font size I think?) because it seems like something that flex-wrap should be able to take care of.

Do we envision the usage of this prop to be a situation where the component is rendered in distinct places where the user will know whether it's a mobile or desktop context? Or are we potentially just pushing the media-query up the stack so that the code for this prop will be something like like :layout="isMinScreen('md') ? 'horizontal' : 'stacked'"?

If it's the last case then my inclination would be to just move that logic into the component and hide the fact that it has different layouts depending on screen size from the user (so the user doesn't have to worry about it).

This is not a blocker or even a solid suggestion, just wondering what the intention is.

[zackkrida]

I also started thinking we might be able to handle this with just css-based media queries. I can look at that when I implement this component in #530 and my 'all' results PR.

[krysal]

Using the isMinScreen() is giving me mismatched HTML problems when the component is server-side rendered. I'll have to take a closer look at how those errors are being handled but for now I'd like to tie this together. I agree that it would be ideal to hide this in the component logic and save us a property here as well.

[obulat]

Krystle, I can repeat what Francisco told me about the borders: in hover and/or hover state, there shouldn't be a gray border, only the pink outline:

Can you see the tiny gray border inside the pink outline here?

[obulat]

The content link looks amazing, @krysal ! I only saw one tiny issue with the border of a hovered button in the comment.

[fcoveram]

I saw what @obulat found before and forgot to comment the change. Thanks Olga for bringing it.

[krysal]

Thanks everyone for reviewing! Looks all good now :)