This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Move the sidebar in the DOM order #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2185 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🟧 priority: high
|
Size Change: -2.21 kB (0%) Total Size: 879 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
fix/sidebar_order
branch
2 times, most recently
from
ac11cfe to
cb94d7c
Compare
|
@obulat how did you generate the tab-order image? Can you also share what the tab-order looks like for RTL languages? |
obulat
force-pushed
the
fix/sidebar_order
branch
from
cb94d7c to
e0004e3
Compare
|
@dhruvkb it's a firefox feature!
|
|
Whoa, that's awesome! In all this time of using Firefox, I never knew about this. |
dhruvkb
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2125 by @obulat
Fixes #2182 by @obulat
Description
This PR moves the sidebar in the DOM order to the position right after the header. Then, using CSS grid, the visual order is changed back to "sidebar on the right". This way, the focus order for keyboard users and for screenreader users is Header -> Filters sidebar -> Main -> Footer.
Normally, using CSS to change the DOM order is bad, but in the case of the search page layout, this actually converts the DOM order into the expected one.
Previously, we used code to manually handle focus after "Tab"/"Shift+Tab" presses on "Filters" button and the last tabbable element in the sidebar and
maincontent. However, this only worked for the keyboard navigation, and not the screenreader navigation.This PR allows us to remove the manual focus management code.
Changes in the tabbing order
Before
After LTR
After RTL
Testing Instructions
Open the search page. Move focus using your keyboard "Tab" key: after the Filters
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin