Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Keyboard navigation to the footer on the search page is impossible #2125

Closed
obulat opened this issue Feb 2, 2023 · 0 comments · Fixed by #2185
Closed

Keyboard navigation to the footer on the search page is impossible #2125

obulat opened this issue Feb 2, 2023 · 0 comments · Fixed by #2185
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon

Comments

@obulat
Copy link
Contributor

obulat commented Feb 2, 2023

Description

If you try to navigate the site using the keyboard Tab, you will not be able to get to the footer. After the last element in main, your focus goes to the beginning (header).

Reproduction

  1. Navigate through the search results using the Tab key.
  2. After passing the external search form, you will see that you land on the header.

Screenshots

Kapture  2023-02-02 at 08 13 07

Additional context

The intention behind the focus management is to allow the user to navigate to the filters sidebar after passing the filters button, instead of going through all of the search results (the natural order). This is the composable that handles it: https://github.com/WordPress/openverse-frontend/blob/main/src/composables/use-focus-filters.ts
We need to move the point of where the focus is moved back to the beginning of the site from the end of "main" to the end of "footer".

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 2, 2023
@obulat obulat self-assigned this Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant