This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix the header scrolling #2155
Merged
Fix the header scrolling #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2155 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
added
🟥 priority: critical
7 tasks
|
Size Change: -4.94 kB (-1%) Total Size: 892 kB
ℹ️ View Unchanged
|
zackkrida
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
This looks like an elegant solution. I think perhaps the default layout would have been better suited as the "special" layout, and the default layout is the scrolling one, but of course I want to land this in time for our launch so we could consider that later. Thanks so much for getting to this quickly; LGTM.
dhruvkb
approved these changes
Feb 8, 2023
obulat
force-pushed
the
fix/split_layouts
branch
from
8ff43f8 to
3b8dcf8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2150 by @obulat
Description
This is a better alternative to #2152 that uses @zackkrida's suggestion about splitting the height settings for "yellow" and "white" pages.
I previously thought that joining the layouts would give us two improvements:
However, I realized that since we used a
keyto make sure that the page is re-rendered to change the layout color, the number of re-renders would not change. Any change in color would cause the whole page to re-render.Also, the second point for setup is not as necessary. We might use the App.vue when we migrate to Nuxt 3 in future.
Having two different layouts (
defaultfor "yellow" full-height pages andcontentLayoutfor the "white" scrollable pages) fixes the issues with header scrolling or the bottom of the footer being cut off.Testing Instructions
Checkout the PR and test that the height is correct on all pages, both on mobile and desktop, especially iOS.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin