This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix the header scrolling by using min-height instead of height #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2152 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🟥 priority: critical
|
Size Change: -584 B (0%) Total Size: 902 kB
ℹ️ View Unchanged
|
dhruvkb
approved these changes
Feb 7, 2023
| @@ -208,7 +208,7 @@ export default { | |||
|
|
|||
| <style scoped> | |||
| .app { | |||
| @apply h-screen h-[100dvh]; | |||
| @apply min-h-screen min-h-[100dvh]; | |||
There was a problem hiding this comment.
I'm still unsure how the priority of these two is set. They have the same specificity and target the same CSS property.
There was a problem hiding this comment.
If the device supports dvh, then the last property is used.
If it does not support dvh, then the last property is discarded, and h-screen (100vh) is used.
There was a problem hiding this comment.
But what if a device supports dvh but somehow the min-h-screen appears later and the device prioritises that?
zackkrida
suggested changes
Feb 7, 2023
I guess the best way is to split the layouts again :) Here's the PR: #2155 I think 🤞 it finally works |
|
Closing in favor of #2155 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2150 by @obulat
Description
This PR replaces the
h-100dvhwithmin-h-100dvhfor theapplayout to fix the header scrolling.Testing Instructions
Checkout the PR and test that the height is correct on all pages, both on mobile and desktop, especially iOS.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin