This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Split homepage VR tests into old and new #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2076 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: -3.65 kB (0%) Total Size: 867 kB
ℹ️ View Unchanged
|
obulat
added
🟨 priority: medium
obulat
force-pushed
the
split_homepage_tests
branch
2 times, most recently
from
10c9aed to
f468b9a
Compare
obulat
force-pushed
the
split_homepage_tests
branch
from
f468b9a to
762ff9c
Compare
7 tasks
7 tasks
dhruvkb
approved these changes
Jan 3, 2023
zackkrida
reviewed
Jan 3, 2023
| ) => { | ||
| const pageWidth = page.viewportSize()?.width | ||
| // TODO: replace when the search types can only be selected using the popover/modal | ||
| console.log("Selecting homepage search type in header mode", headerMode) |
There was a problem hiding this comment.
Suggested change
| console.log("Selecting homepage search type in header mode", headerMode) | |
| // console.log("Selecting homepage search type in header mode", headerMode) |
Any reason to keep this?
There was a problem hiding this comment.
It's removed back in the further PRs :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1433 by @panchovm
Description
This PR was created to make the #2075 easier to review by removing the changes to the homepage snapshots that are unrelated to the new layout changes.
Testing Instructions
This PR is failing an e2e test in the CI because on smaller screens on the new homepage, it expects to see the search type popover, but there's still a row of button from the old design.- I've commented out the new tests, so now the tests here pass.I think it's better not to add any changes, because we'd need to revert those changes in #2075 later. It's easier to just merge this PR as part of #2075.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin