Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Move new homepage and 404 to the default layout #2075

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Move new homepage and 404 to the default layout #2075

merged 4 commits into from
Jan 5, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Dec 28, 2022 •
edited
Loading

Fixes

Related to #1433 by @panchovm

Description

This PR simplifies the code for page layouts for the new designs. It moves the home and 404 pages to the default layout, so there's no more need to add header/footer to them as they are available in the layout.

This PR does not fix the content switcher on the home page.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions
Copy link

github-actions bot commented Dec 28, 2022 •
edited
Loading

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2075
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2075/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Dec 28, 2022
@github-actions
Copy link

github-actions bot commented Dec 28, 2022 •
edited
Loading

Size Change: +15.4 kB (+2%)

Total Size: 886 kB

Filename Size Change
./.nuxt/dist/client/202.js 0 B -272 B (removed) 🏆
./.nuxt/dist/client/202.modern.js 0 B -276 B (removed) 🏆
./.nuxt/dist/client/203.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 143 kB -314 B (0%)
./.nuxt/dist/client/app.modern.js 117 kB -416 B (0%)
./.nuxt/dist/client/commons/app.js 86.7 kB +26 B (0%)
./.nuxt/dist/client/commons/app.modern.js 77.4 kB -16 B (0%)
./.nuxt/dist/client/components/v-home-gallery.modern.js 4.79 kB +18 B (0%)
./.nuxt/dist/client/components/v-sources-table.js 16.6 kB +10 B (0%)
./.nuxt/dist/client/pages/audio/_id.js 7.96 kB +11 B (0%)
./.nuxt/dist/client/pages/image/_id.js 9.27 kB +10 B (0%)
./.nuxt/dist/client/pages/index.js 7.96 kB +423 B (+6%) 🔍
./.nuxt/dist/client/pages/index.modern.js 7.85 kB +373 B (+5%) 🔍
./.nuxt/dist/client/pages/search/audio.modern.js 3.65 kB +11 B (0%)
./.nuxt/dist/client/pages/sources.js 1.55 kB +30 B (+2%)
./.nuxt/dist/client/pages/sources.modern.js 1.54 kB +26 B (+2%)
./.nuxt/dist/client/runtime.js 2.54 kB -19 B (-1%)
./.nuxt/dist/client/runtime.modern.js 2.54 kB -22 B (-1%)
./.nuxt/dist/client/vendors/app.js 63.7 kB +17 B (0%)
./.nuxt/dist/client/195.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/195.modern.js 277 B +277 B (new file) 🆕
./.nuxt/dist/client/196.js 1.85 kB +1.85 kB (new file) 🆕
./.nuxt/dist/client/components/v-homepage-content.js 950 B +950 B (new file) 🆕
./.nuxt/dist/client/components/v-homepage-content.modern.js 953 B +953 B (new file) 🆕
./.nuxt/dist/client/components/v-image-carousel.js 4.76 kB +4.76 kB (new file) 🆕
./.nuxt/dist/client/components/v-image-carousel.modern.js 4.74 kB +4.74 kB (new file) 🆕
./.nuxt/dist/client/components/v-old-homepage-content.js 1.88 kB +1.88 kB (new file) 🆕
./.nuxt/dist/client/components/v-old-homepage-content.modern.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/components/loading-icon.js 747 B -1 B (0%)
./.nuxt/dist/client/components/loading-icon.modern.js 748 B -3 B (0%)
./.nuxt/dist/client/components/table-sort-icon.js 508 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 514 B +1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.js 7.49 kB -1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.modern.js 5.01 kB +6 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 357 B 0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 361 B +2 B (+1%)
./.nuxt/dist/client/components/v-audio-details.js 2.53 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-details.modern.js 1.78 kB +2 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB -2 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB +2 B (0%)
./.nuxt/dist/client/components/v-audio-track.js 5.19 kB -2 B (0%)
./.nuxt/dist/client/components/v-audio-track.modern.js 5.14 kB +6 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 538 B 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 542 B -1 B (0%)
./.nuxt/dist/client/components/v-bone.js 685 B +1 B (0%)
./.nuxt/dist/client/components/v-bone.modern.js 687 B -2 B (0%)
./.nuxt/dist/client/components/v-box-layout.js 1.2 kB 0 B
./.nuxt/dist/client/components/v-box-layout.modern.js 1.2 kB 0 B
./.nuxt/dist/client/components/v-content-link.js 1.11 kB -1 B (0%)
./.nuxt/dist/client/components/v-content-link.modern.js 1.09 kB -1 B (0%)
./.nuxt/dist/client/components/v-content-page.js 467 B +1 B (0%)
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 779 B +4 B (+1%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 779 B -3 B (0%)
./.nuxt/dist/client/components/v-content-report-form.js 6.08 kB 0 B
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.57 kB +2 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.js 1.22 kB +1 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.22 kB 0 B
./.nuxt/dist/client/components/v-copy-button.js 3.98 kB -1 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 3.99 kB -4 B (0%)
./.nuxt/dist/client/components/v-copy-license.js 1 kB 0 B
./.nuxt/dist/client/components/v-copy-license.modern.js 1 kB +2 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.85 kB -1 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.83 kB -3 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.js 749 B 0 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js 752 B -1 B (0%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB +2 B (0%)
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB +5 B (0%)
./.nuxt/dist/client/components/v-error-section.js 373 B +1 B (0%)
./.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./.nuxt/dist/client/components/v-external-search-form.js 3.09 kB +2 B (0%)
./.nuxt/dist/client/components/v-external-search-form.modern.js 3.06 kB +3 B (0%)
./.nuxt/dist/client/components/v-external-source-list.js 2.55 kB +3 B (0%)
./.nuxt/dist/client/components/v-external-source-list.modern.js 2.52 kB +2 B (0%)
./.nuxt/dist/client/components/v-full-layout.js 1.59 kB +3 B (0%)
./.nuxt/dist/client/components/v-full-layout.modern.js 1.59 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB +8 B (0%)
./.nuxt/dist/client/components/v-home-gallery.js 4.8 kB +8 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.js 993 B +1 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.modern.js 996 B -1 B (0%)
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-details.js 2.15 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-details.modern.js 1.42 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-grid.js 4.88 kB -5 B (0%)
./.nuxt/dist/client/components/v-image-grid.modern.js 2.42 kB -3 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.js 521 B 0 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 526 B +2 B (0%)
./.nuxt/dist/client/components/v-load-more.js 3.16 kB -1 B (0%)
./.nuxt/dist/client/components/v-load-more.modern.js 683 B -1 B (0%)
./.nuxt/dist/client/components/v-media-license.js 818 B -2 B (0%)
./.nuxt/dist/client/components/v-media-license.modern.js 828 B 0 B
./.nuxt/dist/client/components/v-media-reuse.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.62 kB +2 B (0%)
./.nuxt/dist/client/components/v-media-tag.js 428 B -1 B (0%)
./.nuxt/dist/client/components/v-media-tag.modern.js 433 B -1 B (0%)
./.nuxt/dist/client/components/v-no-results.js 2.75 kB +1 B (0%)
./.nuxt/dist/client/components/v-no-results.modern.js 2.72 kB +1 B (0%)
./.nuxt/dist/client/components/v-radio.js 1.51 kB +2 B (0%)
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB +1 B (0%)
./.nuxt/dist/client/components/v-related-audio.js 1.25 kB -1 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.25 kB -2 B (0%)
./.nuxt/dist/client/components/v-related-images.js 1.05 kB 0 B
./.nuxt/dist/client/components/v-related-images.modern.js 2.98 kB -6 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 965 B 0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 969 B +1 B (0%)
./.nuxt/dist/client/components/v-row-layout.js 1.7 kB +1 B (0%)
./.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB +3 B (0%)
./.nuxt/dist/client/components/v-scroll-button.js 813 B -1 B (0%)
./.nuxt/dist/client/components/v-scroll-button.modern.js 819 B 0 B
./.nuxt/dist/client/components/v-search-grid.js 5.43 kB +3 B (0%)
./.nuxt/dist/client/components/v-search-grid.modern.js 5.39 kB +2 B (0%)
./.nuxt/dist/client/components/v-search-results-title.js 655 B -1 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 656 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.js 792 B -1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.modern.js 770 B +1 B (0%)
./.nuxt/dist/client/components/v-server-timeout.js 299 B -1 B (0%)
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.37 kB +2 B (0%)
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 894 B -2 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.js 885 B -2 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 894 B +4 B (0%)
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB +1 B (0%)
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB -1 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js 16.6 kB +8 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 299 B +1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/about.js 1.51 kB +2 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.51 kB 0 B
./.nuxt/dist/client/pages/audio/_id.modern.js 4.79 kB +4 B (0%)
./.nuxt/dist/client/pages/external-sources.js 1.53 kB +2 B (0%)
./.nuxt/dist/client/pages/external-sources.modern.js 1.53 kB 0 B
./.nuxt/dist/client/pages/feedback.js 1.31 kB +1 B (0%)
./.nuxt/dist/client/pages/feedback.modern.js 1.31 kB +3 B (0%)
./.nuxt/dist/client/pages/image/_id.modern.js 7.33 kB -1 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.22 kB +1 B (0%)
./.nuxt/dist/client/pages/preferences.modern.js 1.2 kB -3 B (0%)
./.nuxt/dist/client/pages/privacy.js 982 B +1 B (0%)
./.nuxt/dist/client/pages/privacy.modern.js 984 B 0 B
./.nuxt/dist/client/pages/search-help.js 1.61 kB -1 B (0%)
./.nuxt/dist/client/pages/search-help.modern.js 1.61 kB -3 B (0%)
./.nuxt/dist/client/pages/search.js 5.1 kB -5 B (0%)
./.nuxt/dist/client/pages/search.modern.js 2.6 kB +5 B (0%)
./.nuxt/dist/client/pages/search/audio.js 6.14 kB -5 B (0%)
./.nuxt/dist/client/pages/search/image.js 660 B 0 B
./.nuxt/dist/client/pages/search/image.modern.js 2.73 kB -4 B (0%)
./.nuxt/dist/client/pages/search/index.js 542 B 0 B
./.nuxt/dist/client/pages/search/index.modern.js 547 B -1 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 243 B 0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 270 B -1 B (0%)
./.nuxt/dist/client/pages/search/video.js 240 B 0 B
./.nuxt/dist/client/pages/search/video.modern.js 243 B -1 B (0%)
./.nuxt/dist/client/vendors/app.modern.js 63.1 kB +7 B (0%)

compressed-size-action

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 28, 2022
@obulat obulat force-pushed the use_default_layout_for_index branch from d9d6e1f to 178090f Compare December 28, 2022 09:44
@obulat obulat mentioned this pull request Dec 29, 2022
Merged
7 tasks
@obulat obulat force-pushed the use_default_layout_for_index branch from 0320ba2 to 51cd53d Compare December 29, 2022 07:52
@obulat obulat changed the base branch from main to split_homepage_tests December 29, 2022 07:53
@obulat obulat marked this pull request as ready for review December 29, 2022 07:56
@obulat obulat requested a review from a team as a code owner December 29, 2022 07:56
@obulat obulat requested review from zackkrida and dhruvkb December 29, 2022 07:56
@obulat obulat force-pushed the use_default_layout_for_index branch 2 times, most recently from 7748983 to 2deb22b Compare December 29, 2022 08:35
@obulat obulat force-pushed the split_homepage_tests branch from de32ab6 to 10c9aed Compare December 30, 2022 08:24
@dhruvkb dhruvkb mentioned this pull request Dec 30, 2022
Closed
@obulat obulat force-pushed the split_homepage_tests branch from 10c9aed to f468b9a Compare January 3, 2023 04:30
@obulat obulat force-pushed the use_default_layout_for_index branch from 2deb22b to f1cfe54 Compare January 3, 2023 04:33
@obulat obulat force-pushed the split_homepage_tests branch from f468b9a to 762ff9c Compare January 3, 2023 06:09
@obulat obulat force-pushed the use_default_layout_for_index branch 2 times, most recently from 107d060 to e2980dc Compare January 3, 2023 06:33
@obulat obulat mentioned this pull request Jan 3, 2023
Merged
7 tasks
@obulat obulat force-pushed the use_default_layout_for_index branch from d52340e to e53c72d Compare January 3, 2023 08:16
@obulat obulat changed the base branch from split_homepage_tests to fix/internal_header_spacings January 3, 2023 08:18
@obulat obulat force-pushed the fix/internal_header_spacings branch from 06818c1 to c9b691c Compare January 3, 2023 09:03
@obulat obulat force-pushed the use_default_layout_for_index branch from e53c72d to 770e674 Compare January 3, 2023 09:31
dhruvkb
dhruvkb approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does merging this PR remove the need to merge #2076? The description in #2076 says "It's easier to just merge this PR as part of #2075."

@obulat
Copy link
Contributor Author

obulat commented Jan 3, 2023

Does merging this PR remove the need to merge #2076? The description in #2076 says "It's easier to just merge this PR as part of #2075."

We can do it that way, yes. I'll update the description.

@zackkrida
Copy link
Member

@obulat I noticed two oddities:

  1. When going from search results to home, the background changes to yellow before the path changes, so for a second the user sees a yellow background behind the search results. This is because the entire page no longer re-renders. We could possibly force a rerender probably by setting a key of the page slug on the root of the default layout.
  2. The preferences page has a yellow background. Not a huge deal but probably quick to fix.

Base automatically changed from fix/internal_header_spacings to main January 4, 2023 02:09
@obulat obulat force-pushed the use_default_layout_for_index branch from 770e674 to 7fab9eb Compare January 4, 2023 02:18
@WordPress WordPress deleted a comment from github-actions bot Jan 4, 2023
@obulat
Copy link
Contributor Author

obulat commented Jan 4, 2023

I added the key to the default layout so that it forces re-rendering if the isWhite value changes, and added the preferences page to the content pages list, so now it has white background.

zackkrida
zackkrida approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@obulat obulat merged commit f2c1694 into main Jan 5, 2023
@obulat obulat deleted the use_default_layout_for_index branch January 5, 2023 04:00
github-actions bot pushed a commit that referenced this pull request Jan 5, 2023
@openverse-bot
Clean preview for PR #2075
bd79a12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@zackkrida zackkrida zackkrida approved these changes

Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obulat @zackkrida @dhruvkb @openverse-bot