Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Classes moved to static class and redundant variant prop removed #1970 #1972 #1973

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Classes moved to static class and redundant variant prop removed #1970 #1972 #1973

merged 3 commits into from
Nov 16, 2022

Conversation

Mayank-Jain-1
Copy link
Contributor

Fixes

Fixes #1970 #1972 by @obulat

Description

  1. As the classes border border-dark-charcoal and border-opacity-20 were no longer dynamic so they were moved to static class.
  2. The variant prop was not being used so it was removed.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Mayank-Jain-1 Mayank-Jain-1 requested a review from a team as a code owner November 15, 2022 11:04
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Nov 15, 2022
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks correct! Nice work @Mayank-Jain-1

@Mayank-Jain-1
Copy link
Contributor Author

I think this looks correct! Nice work @Mayank-Jain-1

Thanks Sir!
Can you tell me how to pass these 2 checks that my PR is failing
image

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick change, and welcome to Openverse, @Mayank-Jain-1 😃

@obulat obulat merged commit 48c6fcc into WordPress:main Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the border color in the LanguageSelect
4 participants