Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
Classes moved to static class and redundant variant prop removed #1970
Browse files Browse the repository at this point in the history
…#1972 (#1973)

* Replace the border color in the LanguageSelect #1970

* border classes moved to static class and variants prop was removed #1970 #1972
  • Loading branch information
Mayank-Jain-1 authored Nov 16, 2022
1 parent 6c397c3 commit 48c6fcc
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions src/components/VSelectField/VSelectField.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<template>
<div
class="relative m-0.5px box-content block w-fit overflow-hidden rounded-sm border text-sm focus-within:m-0 focus-within:border-1.5 focus-within:border-pink hover:border-dark-charcoal focus-within:hover:border-pink"
:class="
variant === 'yellow' ? 'border-[#d6bb32]' : 'border-dark-charcoal-20'
"
class="relative m-0.5px box-content block w-fit overflow-hidden rounded-sm border border-dark-charcoal border-opacity-20 text-sm focus-within:m-0 focus-within:border-1.5 focus-within:border-pink hover:border-dark-charcoal focus-within:hover:border-pink"
>
<div class="pointer-events-none absolute inset-y-0 my-auto h-fit start-2">
<slot name="start" />
Expand Down Expand Up @@ -100,14 +97,6 @@ const VSelectField = defineComponent({
type: Array as PropType<Choice[]>,
default: () => [],
},
/**
* the stylistic variant of the select field to use; The 'yellow' variant
* has a `#d6bb32` border (20% dark charcoal on top of brand yellow).
*/
variant: {
type: String as PropType<'regular' | 'yellow'>,
default: 'regular',
},
},
// using non-native event name to ensure the two are not mixed
emits: {
Expand Down

0 comments on commit 48c6fcc

Please sign in to comment.