This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Typescriptify VModal components #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1926 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
|
Size Change: -7.47 kB (-1%) Total Size: 808 kB
ℹ️ View Unchanged
|
dhruvkb
approved these changes
Oct 27, 2022
| @@ -29,11 +32,11 @@ import { defineComponent } from '@nuxtjs/composition-api' | |||
| import VLogoLoader from '~/components/VLogoLoader/VLogoLoader.vue' | |||
| import VButton from '~/components/VButton.vue' | |||
|
|
|||
| import OpenverseLogoText from '~/assets/icons/openverse-logo-text.svg?inline' | |||
| import OpenverseLogoText from '~/assets/icons/openverse-logo-text.svg' | |||
There was a problem hiding this comment.
I don't remember if there was a specific reason we are getting rid of ?inline. But this is leading to the SVG tag being duplicated in both the SVG file and in the HTML.
There was a problem hiding this comment.
I wrote about the reasons in this issue: https://github.com/WordPress/openverse-frontend/issues/1715.
I haven't noticed the duplication, I'll look into it, thank you!
There was a problem hiding this comment.
I don't see the SVG tag duplication, @dhruvkb:
|
Based on the low urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was updated 5 day(s) ago. PRs labelled with low urgency are expected to be reviewed within 5 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
sarayourfriend
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1925 by @obulat
Description
This PR converts JSDoc types to TS syntax, and adds the
VModaldirectory totsconfig.jsonTesting Instructions
The
typesstep of CI should pass.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin