Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add types to VModal components #1925

Closed
1 task done
obulat opened this issue Oct 20, 2022 · 0 comments · Fixed by #1926
Closed
1 task done

Add types to VModal components #1925

obulat opened this issue Oct 20, 2022 · 0 comments · Fixed by #1926
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@obulat
Copy link
Contributor

obulat commented Oct 20, 2022

Description

Add type checking to components inside VModal. Make sure to add the directory to tsconfig.json's include list.

Additional context
The VModalContent imports an SVG logo converting it to a component with ?inline, which cannot be type-checked. It should be replaced with an svg element similar to how it's used in VIcon.
Part of an ongoing effort to add type checking to parts of the project that can be type checked.

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 20, 2022
@obulat obulat added this to the TypeScriptification milestone Oct 20, 2022
@obulat obulat self-assigned this Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant